Temporarily disabling mixed-content bocking by default. Will re-land with an infobar/bypass optio...

Temporarily disabling mixed-content bocking by default. Will re-land with an infobar/bypass option and may alter the hueristic for blocking.

BUG=81637
TEST=None.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85954

[commit-bot: I haz the power, 2011-05-19 17:53:22]

No comments yet.

[darin (slow to review), 2011-05-19 18:00:17]

LGTM

[commit-bot: I haz the power, 2011-05-19 19:49:38]

Change committed as 85954

[cevans, 2011-05-20 00:40:18]

Review minus.
Or whatever the Chromium convention is :)

Although this patch appears trivially correct, it breaks the semantics of
--allow-running-insecure-content (which by Chrome convention would now
become --no-running-insecure-content to permit the option to still be
toggled, AFAIK. Seems like this patch will lead us in to Chrome 13 with no
way to disable running of insecure content)

This was noted via e-mail yesterday, prior to this change.

Justin, if yourself or Peter is tackling the infobar and flag re-flip over
the next few days, then no need to action this NACK.

On Thu, May 19, 2011 at 11:00 AM, <darin@chromium.org> wrote:

> LGTM
>
>
> http://codereview.chromium.org/7033026/
>

[Bernhard Bauer, 2011-05-20 10:57:37]

On 2011/05/20 00:40:18, cevans wrote:
> Review minus.
> Or whatever the Chromium convention is :)
> 
> Although this patch appears trivially correct, it breaks the semantics of
> --allow-running-insecure-content (which by Chrome convention would now
> become --no-running-insecure-content to permit the option to still be
> toggled, AFAIK. Seems like this patch will lead us in to Chrome 13 with no
> way to disable running of insecure content)

This just changes the default value, so --allow-running-insecure-content will be
a no-op, and we should add --no-running-insecure-content, but it won't
permanently break anything.

> This was noted via e-mail yesterday, prior to this change.
> 
> Justin, if yourself or Peter is tackling the infobar and flag re-flip over
> the next few days, then no need to action this NACK.
> 
> On Thu, May 19, 2011 at 11:00 AM, <mailto:darin@chromium.org> wrote:
> 
> > LGTM
> >
> >
> > http://codereview.chromium.org/7033026/
> >