Adding support for loading custom locale resources using a command line flag

Adding support for loading custom locale resources using a command line flag.

Loading pseudo-locale will now be done by passing --lang=myLocale --locale_res_path=path/to/pseudo-locale.pak

This patch doesn't work on Windows.

BUG=73052
TEST=NONE


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86426

[ofri, 2011-05-19 12:11:55]

Hi Guys, do you mind take a look?

[jeremy, 2011-05-19 16:08:46]

http://codereview.chromium.org/7033022/diff/1/ui/base/resource/resource_bundl...
File ui/base/resource/resource_bundle.cc (right):

http://codereview.chromium.org/7033022/diff/1/ui/base/resource/resource_bundl...
ui/base/resource/resource_bundle.cc:20: const std::string
kLocaleResourcePathSwitch = "locale_res_path";
Need a comment block describing what this does and why we need it, also how
about a more descriptive switch, perhaps:
"force_resource_load_from_path"

http://codereview.chromium.org/7033022/diff/1/ui/base/resource/resource_bundle.h
File ui/base/resource/resource_bundle.h (right):

http://codereview.chromium.org/7033022/diff/1/ui/base/resource/resource_bundl...
ui/base/resource/resource_bundle.h:54: extern const std::string
kLocaleResourcePathSwitch;
Should be defined in chrome/common/chrome_switches.h

[Mark Mentovai, 2011-05-19 23:20:30]

I think this is fine, I expect to LG it when you address Jeremy’s requests.

[ofri, 2011-05-23 08:42:50]

Uploaded a new version. Do you mind take another look?

http://codereview.chromium.org/7033022/diff/1/ui/base/resource/resource_bundl...
File ui/base/resource/resource_bundle.cc (right):

http://codereview.chromium.org/7033022/diff/1/ui/base/resource/resource_bundl...
ui/base/resource/resource_bundle.cc:20: const std::string
kLocaleResourcePathSwitch = "locale_res_path";
On 2011/05/19 16:08:46, jeremy wrote:
> Need a comment block describing what this does and why we need it, also how
> about a more descriptive switch, perhaps:
> "force_resource_load_from_path"

Well, since it only overrides the locale resources, how about
"force_locale_resources_path"?

http://codereview.chromium.org/7033022/diff/1/ui/base/resource/resource_bundle.h
File ui/base/resource/resource_bundle.h (right):

http://codereview.chromium.org/7033022/diff/1/ui/base/resource/resource_bundl...
ui/base/resource/resource_bundle.h:54: extern const std::string
kLocaleResourcePathSwitch;
On 2011/05/19 16:08:46, jeremy wrote:
> Should be defined in chrome/common/chrome_switches.h

Done.

[Mark Mentovai, 2011-05-23 16:20:34]

LG otherwise

http://codereview.chromium.org/7033022/diff/5001/chrome/common/chrome_switche...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/7033022/diff/5001/chrome/common/chrome_switche...
chrome/common/chrome_switches.cc:578: const char
kForceLocaleResourcesPathSwitch[] = "force_locale_resources_path";
I would just call this

const char kLocalePakSwitch[] = "locale_pak"

[ofri, 2011-05-24 12:12:44]

PTAL

[jeremy, 2011-05-24 12:17:05]

LGTM

[commit-bot: I haz the power, 2011-05-24 12:37:03]

Try job failure for 7033022-8001 on linux:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux&numb...

[commit-bot: I haz the power, 2011-05-24 13:10:53]

Try job failure for 7033022-8001 on win:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[jeremy, 2011-05-24 13:40:31]

LGTM

[commit-bot: I haz the power, 2011-05-24 13:41:21]

Presubmit check for 7033022-10004 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: base/base_switches.cc,base/base_switches.h

[Mark Mentovai, 2011-05-24 13:46:03]

LGTM otherwise

http://codereview.chromium.org/7033022/diff/10004/base/base_switches.cc
File base/base_switches.cc (right):

http://codereview.chromium.org/7033022/diff/10004/base/base_switches.cc#newco...
base/base_switches.cc:26: const char kLocalePak[] = "locale_pak";
All of the |= "value"| in this file seem to be aligned horizontally.

I don’t care for that style, but you should be consistent with what this file
does.

[ofri, 2011-05-24 13:49:09]

Sorry about the alignment. Completely missed it.

[Mark Mentovai, 2011-05-24 13:50:10]

LGTM

ui_switches would be preferable but it doesn’t exist.

[commit-bot: I haz the power, 2011-05-24 14:53:52]

Change committed as 86426