Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5908)

Unified Diff: chrome/browser/download/download_browsertest.cc

Issue 7033021: Mark DownloadTest.BrowserCloseAfterDownload as failing on all platforms (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_browsertest.cc
diff --git a/chrome/browser/download/download_browsertest.cc b/chrome/browser/download/download_browsertest.cc
index 750b8059194ae0399f82705695c77d051cec01ef..2febbcb4451e67be9b125b18218d9a5eeab7e504 100644
--- a/chrome/browser/download/download_browsertest.cc
+++ b/chrome/browser/download/download_browsertest.cc
@@ -1320,13 +1320,9 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, ChromeURLAfterDownload) {
// Test for crbug.com/12745. This tests that if a download is initiated from
// a chrome:// page that has registered and onunload handler, the browser
// will be able to close.
-// Fails on Windows and Linux. http://crbug.com/82278
-#if defined(OS_WIN) || defined(OS_LINUX)
-#define MAYBE_BrowserCloseAfterDownload FAILS_BrowserCloseAfterDownload
-#else
-#define MAYBE_BrowserCloseAfterDownload BrowserCloseAfterDownload
-#endif
-IN_PROC_BROWSER_TEST_F(DownloadTest, MAYBE_BrowserCloseAfterDownload) {
+// After several correct executions, this test starts failing on the build
+// bots and then continues to fail consistently. http://crbug.com/82278
+IN_PROC_BROWSER_TEST_F(DownloadTest, FAILS_BrowserCloseAfterDownload) {
GURL downloads_url(chrome::kAboutFlagsURL);
FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
GURL download_url(URLRequestMockHTTPJob::GetMockUrl(file));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698