Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7033020: When inlining fails, disable optimization of the proper function. (Closed)

Created:
9 years, 7 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

When inlining fails, disable optimization of the proper function. Also, refactor disabling of optimization to make it easier to ensure that both SharedFunctionInfo and Code get disabled. R=whesse@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7963

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -48 lines) Patch
M src/compiler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler.cc View 6 chunks +23 lines, -30 lines 0 comments Download
M src/hydrogen.h View 3 chunks +5 lines, -14 lines 0 comments Download
M src/hydrogen.cc View 6 chunks +22 lines, -4 lines 0 comments Download
M src/objects.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 7 months ago (2011-05-19 11:33:28 UTC) #1
William Hesse
9 years, 7 months ago (2011-05-19 13:09:31 UTC) #2 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698