Issue 7032013: Adapt to new icon interface from WebFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7032013: Adapt to new icon interface from WebFrame (Closed)

Created:
9 years, 7 months ago by michaelbai

Modified:
9 years, 7 months ago

Reviewers:
jamesr, sky

CC:
chromium-reviews, jam, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Adapt to new icon interface from WebFrame - Adapt to the new icon methods from both WebFrame and WebFrameClient. - Touch icons will be fetched and stored if kEnableTouchIcon=1, Currently it is disabled by default. - Moved the kEnableTouchIcon definition to chrome_constants so it could be seen in both browser and renderer code. BUG=71571 TEST=Tested by existent unit test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85651

Patch Set 1 #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -19 lines)			Patch
M	chrome/browser/defaults.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/defaults.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/favicon/favicon_tab_helper.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_constants.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_constants.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/renderer/chrome_render_view_observer.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/renderer/chrome_render_view_observer.cc	View	4 chunks	+40 lines, -7 lines	1 comment	Download
M	content/renderer/render_view.h	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	content/renderer/render_view.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	content/renderer/render_view_observer.h	View	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

9 years, 7 months ago (2011-05-17 16:08:50 UTC) #3

LGTM

http://codereview.chromium.org/7032013/diff/1/chrome/renderer/chrome_render_v...
File chrome/renderer/chrome_render_view_observer.cc (right):

http://codereview.chromium.org/7032013/diff/1/chrome/renderer/chrome_render_v...
chrome/renderer/chrome_render_view_observer.cc:120: case WebIconURL::TypeFavicon
:
no spaces between type and colon (here and on all other lines of this switch).

Expand Messages | Collapse Messages