Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7032: Patch by Thatcher Ulrich <tulrich@google.com>.... (Closed)

Created:
12 years, 2 months ago by ojan
Modified:
9 years, 7 months ago
Reviewers:
Thatcher Ulrich
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Patch by Thatcher Ulrich <tulrich@google.com>;. Implement "iframe shim" behavior for windowed plugins. In FF and IE on windows, iframes are implemented as native HWNDs. This has the side effect that iframes display on top of windowed plugins. This side effect has long been known as a workaround for allowing HTML elements to appear above plugin content. BUG=1788 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3137

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+771 lines, -172 lines) Patch
M base/base.xcodeproj/project.pbxproj View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M base/build/base_gfx.vcproj View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
D base/gfx/bitmap_header.h View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
D base/gfx/bitmap_header.cc View 1 2 1 chunk +0 lines, -64 lines 0 comments Download
M base/gfx/bitmap_platform_device_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + base/gfx/gdi_util.h View 2 chunks +8 lines, -4 lines 0 comments Download
A + base/gfx/gdi_util.cc View 2 chunks +17 lines, -1 line 0 comments Download
M base/gfx/native_theme.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M base/gfx/vector_canvas_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M base/gfx/vector_device.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M base/tuple.h View 1 2 12 chunks +121 lines, -2 lines 0 comments Download
M base/tuple_unittest.cc View 1 2 4 chunks +18 lines, -1 line 0 comments Download
M chrome/browser/drag_utils.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printing_layout_uitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/render_widget_host.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/render_widget_host_hwnd.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/ipc_message_macros.h View 1 2 4 chunks +22 lines, -0 lines 0 comments Download
M chrome/common/ipc_message_utils.h View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M chrome/common/plugin_messages_internal.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/render_messages.h View 1 2 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/win_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/webplugin_delegate_stub.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/plugin/webplugin_delegate_stub.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M chrome/plugin/webplugin_proxy.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 2 3 chunks +9 lines, -5 lines 0 comments Download
M webkit/build/glue/glue.vcproj View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/pending/plugins/iframe-shims.html View 1 chunk +144 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/pending/plugins/iframe-shims-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
webkit/data/layout_tests/pending/plugins/simple_blank.swf View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl.h View 1 2 5 chunks +11 lines, -3 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl.cc View 1 2 7 chunks +29 lines, -16 lines 0 comments Download
A webkit/glue/stacking_order_iterator.h View 1 chunk +73 lines, -0 lines 0 comments Download
A webkit/glue/stacking_order_iterator.cc View 1 chunk +137 lines, -0 lines 0 comments Download
M webkit/glue/webcursor.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webplugin.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/glue/webplugin_delegate.h View 1 2 2 chunks +11 lines, -5 lines 0 comments Download
M webkit/glue/webplugin_impl.h View 1 2 4 chunks +17 lines, -1 line 0 comments Download
M webkit/glue/webplugin_impl.cc View 1 2 10 chunks +60 lines, -7 lines 0 comments Download
M webkit/port/platform/graphics/ImageSkia.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/port/platform/graphics/SkiaUtils.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Thatcher Ulrich
12 years, 2 months ago (2008-10-09 21:51:06 UTC) #1 
LGTM

See one note below about a long line I missed earlier.

http://codereview.chromium.org/7032/diff/1/42
File chrome/plugin/webplugin_delegate_stub.cc (right):

http://codereview.chromium.org/7032/diff/1/42#newcode245
Line 245: window_rect, clip_rect, cutout_rects, visible, windowless_buffer,
background_buffer);
long line

Powered by Google App Engine
This is Rietveld 408576698