Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5970)

Unified Diff: chrome/browser/ui/webui/ntp/most_visited_handler.cc

Issue 7031078: Retry r88137: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix for test failures Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/ntp/favicon_webui_handler.cc ('k') | chrome/browser/ui/webui/ntp/new_tab_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/ntp/most_visited_handler.cc
diff --git a/chrome/browser/ui/webui/ntp/most_visited_handler.cc b/chrome/browser/ui/webui/ntp/most_visited_handler.cc
index 8d78c4ac9e24657be5f5fcd4499466353e881813..712823c48d82ddbc3fb9525ba4d2628b3dff06d2 100644
--- a/chrome/browser/ui/webui/ntp/most_visited_handler.cc
+++ b/chrome/browser/ui/webui/ntp/most_visited_handler.cc
@@ -84,8 +84,6 @@ WebUIMessageHandler* MostVisitedHandler::Attach(WebUI* web_ui) {
}
void MostVisitedHandler::RegisterMessages() {
- // Register ourselves as the handler for the "getMostSisited" message from
- // Javascript.
web_ui_->RegisterMessageCallback("getMostVisited",
NewCallback(this, &MostVisitedHandler::HandleGetMostVisited));
@@ -291,10 +289,12 @@ void MostVisitedHandler::SetPagesValueFromTopSites(
if (url.url.spec() == l10n_util::GetStringUTF8(IDS_CHROME_WELCOME_URL)) {
page_value->SetString("thumbnailUrl",
"chrome://theme/IDR_NEWTAB_CHROME_WELCOME_PAGE_THUMBNAIL");
+ page_value->SetString("faviconDominantColor", "rgb(0, 147, 60)");
tony 2011/06/09 20:37:23 Nit: Might be worth commenting what these colors a
Evan Stade 2011/06/09 20:51:07 I did once ask someone in a code review to do this
} else if (url.url.spec() ==
l10n_util::GetStringUTF8(IDS_THEMES_GALLERY_URL)) {
page_value->SetString("thumbnailUrl",
"chrome://theme/IDR_NEWTAB_THEMES_GALLERY_THUMBNAIL");
+ page_value->SetString("faviconDominantColor", "rgb(63, 132, 197)");
}
history::TopSites* ts = web_ui_->GetProfile()->GetTopSites();
« no previous file with comments | « chrome/browser/ui/webui/ntp/favicon_webui_handler.cc ('k') | chrome/browser/ui/webui/ntp/new_tab_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698