Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 7031074: Cleanup unused lithium instructions. (Closed)

Created:
9 years, 6 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Cleanup unused lithium instructions. Instructions that have side effects can never have EmitAtUses() true. These instructions (CmpTAndBranch, InstanceOfAndBranch) are therefore never generated and can therefor be safely removed. Committed: http://code.google.com/p/v8/source/detail?r=8220

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -239 lines) Patch
M src/arm/lithium-arm.h View 4 chunks +0 lines, -27 lines 0 comments Download
M src/arm/lithium-arm.cc View 3 chunks +5 lines, -19 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +0 lines, -33 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +0 lines, -31 lines 0 comments Download
M src/ia32/lithium-ia32.h View 4 chunks +0 lines, -30 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 4 chunks +5 lines, -21 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M src/x64/lithium-x64.h View 4 chunks +0 lines, -27 lines 0 comments Download
M src/x64/lithium-x64.cc View 3 chunks +5 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years, 6 months ago (2011-06-07 14:47:59 UTC) #1
Kevin Millikin (Chromium)
9 years, 6 months ago (2011-06-08 10:48:08 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698