Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 7031069: New infobar icons (Closed)

Created:
9 years, 6 months ago by sail
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

New infobar icons Changes are: - all icons are 32x32. Previously icons were 26x26, 32x32 or some even bigger - all icons are gray scale - the chromium/google version of the translate icon has been replaced by a single common one Once this is checked in there will be a few more changes coming: - make the icon view in the infobar 32x32 with no scaling - change the infobar background gradient to grayscale (currently it's blue on windows, yellow on mac, and gray in a translate) Screenshots: http://www.dropmocks.com/mV7FH Ran pngcrush -brute -reduce on new icons. chrome/app/themes size: - before: 8602624 bytes - after: 8605184 bytes BUG=80432 TEST=Compiled and ran on Mac. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88152

Patch Set 1 #

Patch Set 2 : Added translate icons #

Patch Set 3 : New infobar icons #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
D chrome/app/theme/chromium/infobar_translate.png View 1 2 Binary file 0 comments Download
D chrome/app/theme/chromium/large_infobar_translate.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/geolocation_infobar_icon.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/infobar_autofill.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/infobar_cookie.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/infobar_didyoumean.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/infobar_insecure.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/infobar_multiple_downloads.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/infobar_plugin.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/infobar_plugin_crashed.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/infobar_questionmark.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/infobar_restore.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/infobar_savepassword.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/infobar_theme.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/infobar_translate.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/large_infobar_autofill.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/large_infobar_cookie.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/large_infobar_didyoumean.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/large_infobar_insecure.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/large_infobar_multiple_downloads.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/large_infobar_plugin.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/large_infobar_plugin_crashed.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/large_infobar_questionmark.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/large_infobar_restore.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/large_infobar_savepassword.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/large_infobar_theme.png View 1 2 Binary file 0 comments Download
A chrome/app/theme/large_infobar_translate.png View 1 2 Binary file 0 comments Download
M chrome/app/theme/theme_resources_large.grd View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M chrome/app/theme/theme_resources_standard.grd View 1 2 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sail
9 years, 6 months ago (2011-06-07 00:37:49 UTC) #1
Emmanuel Saint-loubert-Bié
LGTM
9 years, 6 months ago (2011-06-07 00:39:55 UTC) #2
Nico
LGTM
9 years, 6 months ago (2011-06-07 00:48:51 UTC) #3
commit-bot: I haz the power
Change committed as 88086
9 years, 6 months ago (2011-06-07 02:23:14 UTC) #4
sail
9 years, 6 months ago (2011-06-07 02:55:18 UTC) #5

          

Powered by Google App Engine
This is Rietveld 408576698