Issue 7031063: Extension API: Rename contentSettings.misc to .global and rename preferences under it.

Issue 7031063: Extension API: Rename contentSettings.misc to .global and rename preferences under it. (Closed)

Created:
9 years, 7 months ago by Bernhard Bauer

Modified:
9 years, 6 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr., USE chromium.org ACCOUNT

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Extension API: Rename contentSettings.misc to .global and rename preferences under it. BUG=71067 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87632

Patch Set 1 #

Patch Set 2 : compile fix #

Patch Set 3 : compile fix #

Patch Set 4 : compile fix #

Patch Set 5 : fix tests #

Patch Set 6 : sync #

Patch Set 7 : fix #

Total comments: 2

Patch Set 8 : sync #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+139 lines, -866 lines)			Patch
M	chrome/browser/extensions/extension_preference_api.cc	View	1 2 3 4 5 6 7	4 chunks	+26 lines, -6 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.json	View	1 2 3 4 5 6 7	1 chunk	+10 lines, -10 lines	0 comments	Download
	chrome/common/extensions/docs/examples/api/preferences/enableReferrer.zip	View	1 2 3 4 5	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html	View	1 2 3 4 5	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/experimental.html	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/common/extensions/docs/experimental.contentSettings.global.html	View	1 2 3 4 5	10 chunks	+22 lines, -22 lines	0 comments	Download
D	chrome/common/extensions/docs/experimental.contentSettings.misc.html	View	1 2 3 4 5	1 chunk	+0 lines, -746 lines	0 comments	Download
M	chrome/common/extensions/docs/samples.json	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/resources/renderer_extension_bindings.js	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/content_settings/clear/test.html	View	1 2 3 4 5 6	1 chunk	+15 lines, -15 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/content_settings/onchange/test.html	View	1 2 3 4 5	1 chunk	+25 lines, -25 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/content_settings/persistent_incognito/test.html	View	1 2 3 4 5	1 chunk	+10 lines, -10 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/content_settings/session_only_incognito/test.html	View	1 2 3 4 5 6	3 chunks	+18 lines, -18 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/content_settings/standard/test.html	View	1 2 3 4 5	1 chunk	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

LGTM what about my suggestion to make these content types and control them via the ...

9 years, 6 months ago (2011-06-01 08:46:43 UTC) #2

Bernhard Bauer

9 years, 6 months ago (2011-06-01 16:48:48 UTC) #3

On 2011/06/01 08:46:43, jochen wrote:
> LGTM
> 
> what about my suggestion to make these content types and control them via the
> contentSettings API?

Good idea, but it would likely involve more changes, so we'd need to investigate
it separately.

http://codereview.chromium.org/7031063/diff/12001/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_preference_api.cc (right):

http://codereview.chromium.org/7031063/diff/12001/chrome/browser/extensions/e...
chrome/browser/extensions/extension_preference_api.cc:105: static Value*
InvertBooleanValue(const Value* value) {
On 2011/06/01 08:46:43, jochen wrote:
> why static and private member? either should be enough

Why not? :-) It's static because it doesn't use object state, and private
because it's only called from within the class.

Expand Messages | Collapse Messages