Issue 7031058: Make the app provider match highlighting use the existing ClassifyMatchXXX() machinery, and set t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7031058: Make the app provider match highlighting use the existing ClassifyMatchXXX() machinery, and set t... (Closed)

Created:
9 years, 7 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Finnur

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make the app provider match highlighting use the existing ClassifyMatchXXX() machinery, and set the correct base styles (NONE rather than DIM for the contents, and URL rather than DIM for the description). This also switches from UTF-8 to UTF-16 for various temps/members since that's the destination encoding for the various AutocompleteMatch fields. BUG=none TEST=App matches in omnibox should have undimmed names and green URLs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86735

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -68 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_match.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/extension_app_provider.h	View		4 chunks	+3 lines, -14 lines	0 comments	Download
M	chrome/browser/autocomplete/extension_app_provider.cc	View	1	4 chunks	+26 lines, -49 lines	1 comment	Download
M	chrome/browser/autocomplete/extension_app_provider_unittest.cc	View	1 2	2 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Finnur

9 years, 7 months ago (2011-05-25 22:26:05 UTC) #2

Nice. LGTM (one nit).

http://codereview.chromium.org/7031058/diff/11/chrome/browser/autocomplete/ex...
File chrome/browser/autocomplete/extension_app_provider.cc (right):

http://codereview.chromium.org/7031058/diff/11/chrome/browser/autocomplete/ex...
chrome/browser/autocomplete/extension_app_provider.cc:27: const string16&
app_name,
Nit: This no longer needs to be on a separate line?

Expand Messages | Collapse Messages

Issue 7031058: Make the app provider match highlighting use the existing ClassifyMatchXXX() machinery, and set t... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages