Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: base/message_pump_glib_x.cc

Issue 7031057: X message pump: Remove the GDK window event filter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_pump_glib_x.cc
diff --git a/base/message_pump_glib_x.cc b/base/message_pump_glib_x.cc
index c694114d2933b97253723f4921ff5919a2f56fd1..b4c8b7d403648f9a6fb0c544558a1e8e2823b7db 100644
--- a/base/message_pump_glib_x.cc
+++ b/base/message_pump_glib_x.cc
@@ -43,6 +43,12 @@ MessagePumpGlibX::MessagePumpGlibX() : base::MessagePumpForUI(),
}
MessagePumpGlibX::~MessagePumpGlibX() {
+ // Remove the filter.
Evan Martin 2011/05/25 18:56:06 I guess this comment isn't very useful, since it's
sadrul 2011/05/25 19:00:05 I agree; it's fairly clear what's happening. Remov
+ gdk_window_remove_filter(NULL, &GdkEventFilter, this);
+
+ // It is not necessary to reset the GDK event handler using
+ // gdk_event_handler_set since it's done in the destructor for
+ // MessagePumpForUI.
}
bool MessagePumpGlibX::ShouldCaptureXEvent(XEvent* xev) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698