X message pump: Remove the GDK window event filter.

X message pump: Remove the GDK window event filter.

This should fix some crashes that end up calling the event filter of a
destroyed message pump.

BUG=none
TEST=some randomly failing unit tests (e.g.  SessionServiceTest.GetCurrentSession)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86672

[Evan Martin, 2011-05-25 18:56:06]

LGTM

http://codereview.chromium.org/7031057/diff/1/base/message_pump_glib_x.cc
File base/message_pump_glib_x.cc (right):

http://codereview.chromium.org/7031057/diff/1/base/message_pump_glib_x.cc#new...
base/message_pump_glib_x.cc:46: // Remove the filter.
I guess this comment isn't very useful, since it's self-evident from the
following line.  Consider either deleting it or saying something about why
you're doing it (e.g. "clean up the filter that we installed in the ctor")

[sadrul, 2011-05-25 19:00:05]

Thanks for the quick review!

http://codereview.chromium.org/7031057/diff/1/base/message_pump_glib_x.cc
File base/message_pump_glib_x.cc (right):

http://codereview.chromium.org/7031057/diff/1/base/message_pump_glib_x.cc#new...
base/message_pump_glib_x.cc:46: // Remove the filter.
On 2011/05/25 18:56:06, Evan Martin wrote:
> I guess this comment isn't very useful, since it's self-evident from the
> following line.  Consider either deleting it or saying something about why
> you're doing it (e.g. "clean up the filter that we installed in the ctor")

I agree; it's fairly clear what's happening. Removed the comment.