Issue 7031046: Add comment better explaining the calling-stubs-from-stubs issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7031046: Add comment better explaining the calling-stubs-from-stubs issue. (Closed)

Created:
9 years, 7 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add comment better explaining the calling-stubs-from-stubs issue. Committed: http://code.google.com/p/v8/source/detail?r=8059

Patch Set 1 #

Total comments: 2

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	src/code-stubs.h	View		3 chunks	+9 lines, -4 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

Suggestion to make it even more obvious. LGTM. http://codereview.chromium.org/7031046/diff/1/src/code-stubs.h File src/code-stubs.h (right): http://codereview.chromium.org/7031046/diff/1/src/code-stubs.h#newcode50 src/code-stubs.h:50: /* ...

9 years, 7 months ago (2011-05-25 12:22:29 UTC) #2

Erik Corry

9 years, 7 months ago (2011-05-25 12:51:06 UTC) #3

http://codereview.chromium.org/7031046/diff/1/src/code-stubs.h
File src/code-stubs.h (right):

http://codereview.chromium.org/7031046/diff/1/src/code-stubs.h#newcode50
src/code-stubs.h:50: /* generated ahead of time.  Therefore inserting a call to
one of    */  \
On 2011/05/25 12:22:29, Kevin Millikin wrote:
> Maybe less ambiguous: "inserting" --> "compiling", and below.  Also below,
> "generating" --> "compiling".

Done.

Expand Messages | Collapse Messages