Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: webkit/plugins/ppapi/ppapi_plugin_instance.h

Issue 7031044: ppapi: Work around a compiler bug where the PPP_Printing_Dev struct is not zeroed out. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: another patchset for commit-bot to chew on Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/ppapi_plugin_instance.h
===================================================================
--- webkit/plugins/ppapi/ppapi_plugin_instance.h (revision 86566)
+++ webkit/plugins/ppapi/ppapi_plugin_instance.h (working copy)
@@ -427,8 +427,12 @@
PPP_Printing_Dev_Combined(const PPP_Printing_Dev_0_3& old_if)
: PPP_Printing_Dev(), // NOTE: The parens are important, to zero-
// initialize the struct.
+ // Except older version of g++ doesn't!
+ // So do it explicitly in the ctor.
QuerySupportedFormats_0_3(old_if.QuerySupportedFormats),
Begin_0_3(old_if.Begin) {
+ QuerySupportedFormats = NULL;
+ Begin = NULL;
PrintPages = old_if.PrintPages;
End = old_if.End;
}
@@ -439,7 +443,6 @@
// The 0.3 version of 'Begin'.
int32_t (*Begin_0_3)(PP_Instance instance,
const struct PP_PrintSettings_Dev_0_3* print_settings);
-
};
scoped_ptr<PPP_Printing_Dev_Combined> plugin_print_interface_;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698