chrome/test/functional/media/media_test_env_names.py - Issue 7031020: Change for preparation for reference-build on perfbot (media)

Side by Side Diff: chrome/test/functional/media/media_test_env_names.py

Issue 7031020: Change for preparation for reference-build on perfbot (media) (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Add a space. Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/test/functional/media/media_test_base.py ('k') | chrome/test/functional/media/media_test_runner.py » ('j') | chrome/test/functional/media/media_test_runner.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 #!/usr/bin/python	1 #!/usr/bin/python

2	2

3 # Copyright (c) 2011 The Chromium Authors. All rights reserved.	3 # Copyright (c) 2011 The Chromium Authors. All rights reserved.

4 # Use of this source code is governed by a BSD-style license that can be	4 # Use of this source code is governed by a BSD-style license that can be

5 # found in the LICENSE file.	5 # found in the LICENSE file.

6	6

7	7

8 class MediaTestEnvNames:	8 class MediaTestEnvNames:

9 """Class that contains all environment names used in media tests.	9 """Class that contains all environment names used in media tests.

10	10

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
48 MEDIA_FILENAME_NICKNAME_ENV_NAME = 'MEDIA_FILENAME_NICKNAME'	48 MEDIA_FILENAME_NICKNAME_ENV_NAME = 'MEDIA_FILENAME_NICKNAME'

49	49

50 # Define the interval for the measurement.	50 # Define the interval for the measurement.

51 MEASURE_INTERVAL_ENV_NAME = 'MEASURE_INTERVALS'	51 MEASURE_INTERVAL_ENV_NAME = 'MEASURE_INTERVALS'

52	52

53 # Define the test scenario file, which contains all operations during tests.	53 # Define the test scenario file, which contains all operations during tests.

54 TEST_SCENARIO_FILE_ENV_NAME = 'TEST_SCENARIO_FILE'	54 TEST_SCENARIO_FILE_ENV_NAME = 'TEST_SCENARIO_FILE'

55	55

56 # Define the test scenario, which contains operations during tests.	56 # Define the test scenario, which contains operations during tests.

57 TEST_SCENARIO_ENV_NAME = 'TEST_SCENARIO'	57 TEST_SCENARIO_ENV_NAME = 'TEST_SCENARIO'

	58

	59 # 'True' to run on a reference build, or 'False' otherwise.
	dennis_jeffrey 2011/05/20 18:10:46 Based on your latest changes, this environment var Based on your latest changes, this environment variable is defined if we want a reference build, and not defined otherwise. So we should update this comment to reflect that. imasaki1 2011/05/20 20:50:14 Done. Show quoted text On 2011/05/20 18:10:46, dennis_jeffrey wrote: > Based on your latest changes, this environment variable is defined if we want a > reference build, and not defined otherwise. So we should update this comment to > reflect that. Done.
	60 REFERENCE_BUILD_ENV_NAME = 'REFERENCE_BUILD'

	61

	62 # Define the location of the binary used for reference build.
	dennis_jeffrey 2011/05/20 18:10:46 May want to clarify in this comment whether the lo May want to clarify in this comment whether the location should be the path to the binary itself, or the path to the folder containing the binary. The name "REFERENCE_BUILD_DIR" implies that it is the path to the folder containing the binary. Is that correct? imasaki1 2011/05/20 20:50:14 Done. Show quoted text On 2011/05/20 18:10:46, dennis_jeffrey wrote: > May want to clarify in this comment whether the location should be the path to > the binary itself, or the path to the folder containing the binary. The name > "REFERENCE_BUILD_DIR" implies that it is the path to the folder containing the > binary. Is that correct? Done.
	63 REFERENCE_BUILD_DIR_ENV_NAME = 'REFERENCE_BUILD_DIR'

OLD	NEW