Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 7029054: Valgrind: Slightly widen a suppression. (Closed)

Created:
9 years, 7 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Valgrind: Slightly widen a suppression. BUG=82717 TEST=none TBR=timurrrr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86252

Patch Set 1 #

Patch Set 2 : correct suppression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Slightly different suppression here: http://build.chromium.org/p/chromium.memory/builders/Linux%20Tests%20%28valgrind%29%283%29/builds/2513/steps/memory%20test%3A%20ui/logs/000000004E18B9A4 Suppression (error hash=#000000004E18B9A4#): { <insert_a_suppression_name_here> Memcheck:Leak fun:_Znw* fun:_ZN6chrome26ChromeContentBrowserClient31BrowserRenderProcessHostCreatedEP24BrowserRenderProcessHost fun:_ZN24BrowserRenderProcessHost4InitEb fun:_ZN14RenderViewHost16CreateRenderViewERKSbItN4base20string16_char_traitsESaItEE ...
9 years, 7 months ago (2011-05-23 05:15:30 UTC) #1
Lei Zhang
+ the right timurrrr
9 years, 7 months ago (2011-05-23 05:15:42 UTC) #2
Lei Zhang
... and put the correct suppression in patch set 2.
9 years, 7 months ago (2011-05-23 05:16:45 UTC) #3
Timur Iskhodzhanov
9 years, 7 months ago (2011-05-23 08:20:00 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698