Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7029009: Add an interface QuotaEvictionHandler. (Closed)

Created:
9 years, 7 months ago by Dai Mikurube (NOT FULLTIME)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., tzik (google)
Visibility:
Public.

Description

Add an interface QuotaEvictionHandler. BUG=61676 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85613

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reflected. #

Patch Set 3 : Renamed DeleteOriginData to EvictOriginData and separated Get...ForEviction out. #

Total comments: 1

Patch Set 4 : Just rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -16 lines) Patch
M webkit/quota/quota_manager.h View 1 2 3 3 chunks +35 lines, -2 lines 0 comments Download
M webkit/quota/quota_manager.cc View 1 2 2 chunks +26 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dai Mikurube (NOT FULLTIME)
9 years, 7 months ago (2011-05-16 13:49:19 UTC) #1
kinuko
http://codereview.chromium.org/7029009/diff/1/webkit/quota/quota_manager.h File webkit/quota/quota_manager.h (right): http://codereview.chromium.org/7029009/diff/1/webkit/quota/quota_manager.h#newcode44 webkit/quota/quota_manager.h:44: int64 /* physical_avail */ >::Type DeleteOriginDataCallback; This callback being ...
9 years, 7 months ago (2011-05-16 13:57:44 UTC) #2
Dai Mikurube (NOT FULLTIME)
9 years, 7 months ago (2011-05-17 04:13:49 UTC) #3
kinuko
lgtm http://codereview.chromium.org/7029009/diff/5002/webkit/quota/quota_manager.h File webkit/quota/quota_manager.h (right): http://codereview.chromium.org/7029009/diff/5002/webkit/quota/quota_manager.h#newcode54 webkit/quota/quota_manager.h:54: StorageType type, Not very sure we want type ...
9 years, 7 months ago (2011-05-17 05:05:59 UTC) #4
Dai Mikurube (NOT FULLTIME)
On 2011/05/17 05:05:59, kinuko wrote: > lgtm > > http://codereview.chromium.org/7029009/diff/5002/webkit/quota/quota_manager.h > File webkit/quota/quota_manager.h (right): > ...
9 years, 7 months ago (2011-05-17 08:18:53 UTC) #5
commit-bot: I haz the power
9 years, 7 months ago (2011-05-17 09:15:50 UTC) #6 
Change committed as 85613

Powered by Google App Engine
This is Rietveld 408576698