Issue 7027034: Revert r922.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7027034: Revert r922. (Closed)

Created:
9 years, 6 months ago by Evan Martin

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai

CC:
gyp-developer_googlegroups.com, Yuki Shiino

Base URL:
https://gyp.googlecode.com/svn/trunk

Visibility:
Public.

Revert r922. We had a 10% build performance regression on the Chrome Windows builders, and this seems likely to be related.

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -8 lines)			Patch
	M	pylib/gyp/input.py	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download

Total messages: 5 (0 generated)

Evan Martin

For reference, the changes in the window of Doom: - make: remove hacks used for ...

9 years, 6 months ago (2011-06-01 16:55:47 UTC) #2

Mark Mentovai

Don’t revert r921, it wouldn’t have caused any build-time differences. r922 could have.

9 years, 6 months ago (2011-06-01 17:23:02 UTC) #3

Mark Mentovai

9 years, 6 months ago (2011-06-01 18:00:49 UTC) #5

LGTM.

I’ve added Yuki to the Cc list so he’s aware of this, since it was his change.