Remove unused multiline attribute in textfield

Remove unused multiline attribute in textfield. Need to be pushed only *after* http://codereview.chromium.org/6975062/ has landed


BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87854

[Emmanuel Saint-loubert-Bié, 2011-06-01 01:12:04]

Mitsuru,

Please review. thank.

-- Emmanuel

[oshima, 2011-06-01 01:29:15]

please include ben or sky in reviewers as well.

about_pane_pubble seems to be having compilation error, but
I guess we can remove it as well?

http://codereview.chromium.org/7027014/diff/2001/views/controls/textfield/nat...
File views/controls/textfield/native_textfield_gtk.cc (right):

http://codereview.chromium.org/7027014/diff/2001/views/controls/textfield/nat...
views/controls/textfield/native_textfield_gtk.cc:38: NOTIMPLEMENTED();  // We
don't support multiline password yet.
you need to remove this line as this will disallow password.

http://codereview.chromium.org/7027014/diff/2001/views/controls/textfield/nat...
views/controls/textfield/native_textfield_gtk.cc:159: !textfield_->read_only());
indent

http://codereview.chromium.org/7027014/diff/2001/views/controls/textfield/nat...
views/controls/textfield/native_textfield_gtk.cc:174:
!textfield_->IsPassword());
indent

http://codereview.chromium.org/7027014/diff/2001/views/controls/textfield/nat...
File views/controls/textfield/native_textfield_views.h (right):

http://codereview.chromium.org/7027014/diff/2001/views/controls/textfield/nat...
views/controls/textfield/native_textfield_views.h:39: // * STYLE_LOWERCASE text.
(not used in chromeos, so maybe not needed)
can you remove (not ... needed)? Since we decide to replace win's text field.
STYLE_LOWERCSE is used in search selection dialog.

[Emmanuel Saint-loubert-Bié, 2011-06-01 01:50:07]

http://codereview.chromium.org/7027014/diff/2001/views/controls/textfield/nat...
File views/controls/textfield/native_textfield_gtk.cc (right):

http://codereview.chromium.org/7027014/diff/2001/views/controls/textfield/nat...
views/controls/textfield/native_textfield_gtk.cc:38: NOTIMPLEMENTED();  // We
don't support multiline password yet.
On 2011/06/01 01:29:15, oshima wrote:
> you need to remove this line as this will disallow password.

Done.

http://codereview.chromium.org/7027014/diff/2001/views/controls/textfield/nat...
views/controls/textfield/native_textfield_gtk.cc:159: !textfield_->read_only());
On 2011/06/01 01:29:15, oshima wrote:
> indent

Done.

http://codereview.chromium.org/7027014/diff/2001/views/controls/textfield/nat...
views/controls/textfield/native_textfield_gtk.cc:174:
!textfield_->IsPassword());
On 2011/06/01 01:29:15, oshima wrote:
> indent

Done.

http://codereview.chromium.org/7027014/diff/2001/views/controls/textfield/nat...
File views/controls/textfield/native_textfield_views.h (right):

http://codereview.chromium.org/7027014/diff/2001/views/controls/textfield/nat...
views/controls/textfield/native_textfield_views.h:39: // * STYLE_LOWERCASE text.
(not used in chromeos, so maybe not needed)
On 2011/06/01 01:29:15, oshima wrote:
> can you remove (not ... needed)? Since we decide to replace win's text field.
> STYLE_LOWERCSE is used in search selection dialog.
I agree but will do that as separate CL

[Emmanuel Saint-loubert-Bié, 2011-06-01 17:28:06]

Hi Scott,

Oshima reviewed and I applied his comments. If it looks good can you please
LGTM. Thanks,

-- Emmanuel

[sky, 2011-06-01 20:39:37]

LGTM

[commit-bot: I haz the power, 2011-06-03 00:53:36]

Can't apply patch for file views/controls/textfield/native_textfield_views.h.
While running patch -p1 --forward --force;
patching file views/controls/textfield/native_textfield_views.h
Hunk #1 FAILED at 36.
1 out of 1 hunk FAILED -- saving rejects to file
views/controls/textfield/native_textfield_views.h.rej