Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issue 7026004: HostContentSettingsMap cleanup (Closed)

Created:
9 years, 7 months ago by Bernhard Bauer
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

HostContentSettingsMap cleanup: Remove obsolete kBlockNonsandboxedPlugins preference; don't send CONTENT_SETTINGS_CHANGED notifications when preferences change. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86300

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : compile fix #

Patch Set 4 : sync; fix test #

Patch Set 5 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -86 lines) Patch
M chrome/browser/content_settings/host_content_settings_map.h View 1 3 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.cc View 1 2 3 4 10 chunks +2 lines, -62 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map_unittest.cc View 1 2 3 1 chunk +1 line, -7 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bernhard Bauer
please review.
9 years, 7 months ago (2011-05-20 12:08:09 UTC) #1
markusheintz_
LGTM
9 years, 7 months ago (2011-05-20 12:48:46 UTC) #2
commit-bot: I haz the power
Can't apply patch for file chrome/browser/content_settings/host_content_settings_map.cc. patching file chrome/browser/content_settings/host_content_settings_map.cc Hunk #1 FAILED at 7. Hunk ...
9 years, 7 months ago (2011-05-23 14:57:55 UTC) #3
commit-bot: I haz the power
9 years, 7 months ago (2011-05-23 17:42:20 UTC) #4
Change committed as 86300

Powered by Google App Engine
This is Rietveld 408576698