chrome/browser/ui/panels/panel_browser_view_browsertest.cc - Issue 7024056: Handle extension webrequest API on the IO thread. This speeds up blocking event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_browser_view_browsertest.cc

Issue 7024056: Handle extension webrequest API on the IO thread. This speeds up blocking event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix broken test Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/profile_impl.cc ('K') | « chrome/browser/renderer_host/chrome_render_message_filter.cc ('k') | chrome/common/extensions/extension_messages.h » ('j') | chrome/renderer/extensions/extension_process_bindings.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/panel_browser_view_browsertest.cc

diff --git a/chrome/browser/ui/panels/panel_browser_view_browsertest.cc b/chrome/browser/ui/panels/panel_browser_view_browsertest.cc

index eeed6ef717e529bf5c0f543b63e8575fa263c5f0..c0e039802205f9696cf3399a67ad3ded26add9f5 100644

--- a/chrome/browser/ui/panels/panel_browser_view_browsertest.cc

+++ b/chrome/browser/ui/panels/panel_browser_view_browsertest.cc

@@ -215,7 +215,7 @@ class PanelBrowserViewTest : public InProcessBrowserTest {

&error);

ASSERT_TRUE(extension.get());

EXPECT_STREQ("", error.c_str());

- browser()->GetProfile()->GetExtensionService()->AddExtension(

+ browser()->GetProfile()->GetExtensionService()->OnLoadSingleExtension(

extension.get());

// Makes sure that async task ExtensionPrefs::OnExtensionInstalled gets a

Mihai Parparita -not on Chrome 2011/06/08 01:11:59 Isn't OnExtensionInstalled invoked directly/synchr

Matt Perry 2011/06/08 20:47:00 I changed it to OnLoadSingleExtension so that it w