Handle extension webrequest API on the IO thread. This speeds up blocking event

chrome/renderer/resources/extension_process_bindings.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This script contains privileged chrome extension related javascript APIs.
 // It is loaded by pages whose URL has the chrome-extension protocol.
 
 var chrome = chrome || {};
 (function() {
   native function GetExtensionAPIDefinition();
   native function StartRequest();
+  native function StartRequestForIOThread();
   native function GetCurrentPageActions(extensionId);
   native function GetExtensionViews();
   native function GetChromeHidden();
   native function GetNextRequestId();
   native function GetNextContextMenuId();
   native function OpenChannelToTab();
   native function GetRenderViewId();
   native function SetIconCommon();
   native function IsExtensionProcess();
   native function IsIncognitoProcess();
@@ skipping 154 matching lines @@
 
     request.args = [];
     for (var k = 0; k < argCount; k++) {
       request.args[k] = args[k];
     }
 
     return request;
   }
 
   // Send an API request and optionally register a callback.
-  function sendRequest(functionName, args, argSchemas, customCallback) {
+  // If |opt_rawargs| is true, don't JSONify the arguments. If
+  // |opt_nativeFunction| is provided, use that instead of StartRequest.
+  function sendRequest(functionName, args, argSchemas, opt_customCallback,

[Mihai Parparita -not on Chrome, 2011/06/08 01:11:59]

The callsites of this are confusing to follow because of all the optional
arguments. Perhaps have a sendRequestOnIOThread wrapper (and sendIconRequest for
the other usecase)?

[Matt Perry, 2011/06/08 20:47:00]

I've changed the optional arguments to a single optional object with named args.
Does that clarify it enough?

+                       opt_rawargs, opt_nativeFunction) {
     var request = prepareRequest(args, argSchemas);
-    if (customCallback) {
-      request.customCallback = customCallback;
+    if (opt_customCallback) {
+      request.customCallback = opt_customCallback;
     }
     // JSON.stringify doesn't support a root object which is undefined.
     if (request.args === undefined)
       request.args = null;
 
-    var sargs = chromeHidden.JSON.stringify(request.args);
+    var sargs = opt_rawargs ?
+        request.args : chromeHidden.JSON.stringify(request.args);
+    var nativeFunction = opt_nativeFunction || StartRequest;
 
     var requestId = GetNextRequestId();
     requests[requestId] = request;
-    var hasCallback = (request.callback || customCallback) ? true : false;
-    return StartRequest(functionName, sargs, requestId, hasCallback);
-  }
-
-  // Send a special API request that is not JSON stringifiable, and optionally
-  // register a callback.
-  function sendCustomRequest(nativeFunction, functionName, args, argSchemas) {
-    var request = prepareRequest(args, argSchemas);
-    var requestId = GetNextRequestId();
-    requests[requestId] = request;
-    return nativeFunction(functionName, request.args, requestId,
-                          request.callback ? true : false);
+    var hasCallback = (request.callback || opt_customCallback) ? true : false;
+    return nativeFunction(functionName, sargs, requestId, hasCallback);
   }
 
   // Helper function for positioning pop-up windows relative to DOM objects.
   // Returns the absolute position of the given element relative to the hosting
   // browser frame.
   function findAbsolutePosition(domElement) {
     var left = domElement.offsetLeft;
     var top = domElement.offsetTop;
 
     // Ascend through the parent hierarchy, taking into account object nesting
@@ skipping 522 matching lines @@
               "The imageData property must contain an ImageData object.");
         }
 
         if (details.imageData.width > iconSize ||
             details.imageData.height > iconSize) {
           throw new Error(
               "The imageData property must contain an ImageData object that " +
               "is no larger than " + iconSize + " pixels square.");
         }
 
-        sendCustomRequest(nativeFunction, name, [details], parameters);
+        sendRequest(name, [details], parameters, null, true, nativeFunction);
       } else if ("path" in details) {
         var img = new Image();
         img.onerror = function() {
           console.error("Could not load " + actionType + " icon '" +
                         details.path + "'.");
         };
         img.onload = function() {
           var canvas = document.createElement("canvas");
           canvas.width = img.width > iconSize ? iconSize : img.width;
           canvas.height = img.height > iconSize ? iconSize : img.height;
 
           var canvas_context = canvas.getContext('2d');
           canvas_context.clearRect(0, 0, canvas.width, canvas.height);
           canvas_context.drawImage(img, 0, 0, canvas.width, canvas.height);
           delete details.path;
           details.imageData = canvas_context.getImageData(0, 0, canvas.width,
                                                           canvas.height);
-          sendCustomRequest(nativeFunction, name, [details], parameters);
+          sendRequest(name, [details], parameters, null, true, nativeFunction);
         };
         img.src = details.path;
       } else {
         throw new Error(
             "Either the path or imageData property must be specified.");
       }
     }
 
     function setExtensionActionIconCommon(details, name, parameters,
                                           actionType) {
@@ skipping 29 matching lines @@
                   this.customCallback);
       return id;
     };
 
     apiFunctions["omnibox.setDefaultSuggestion"].handleRequest =
         function(details) {
       var parseResult = parseOmniboxDescription(details.description);
       sendRequest(this.name, [parseResult], this.definition.parameters);
     };
 
+    apiFunctions["experimental.webRequest.addEventListener"].handleRequest =
+        function() {
+      var args = Array.prototype.slice.call(arguments);
+      sendRequest(this.name, args, this.definition.parameters,
+                  null, false, StartRequestForIOThread);
+    };
+
+    apiFunctions["experimental.webRequest.eventHandled"].handleRequest =
+        function() {
+      var args = Array.prototype.slice.call(arguments);
+      sendRequest(this.name, args, this.definition.parameters,
+                  null, false, StartRequestForIOThread);
+    };
+
     apiFunctions["contextMenus.create"].customCallback =
         function(name, request, response) {
       if (chrome.extension.lastError) {
         return;
       }
 
       var id = request.args[0].generatedId;
 
       // Set up the onclick handler if we were passed one in the request.
       var onclick = request.args.length ? request.args[0].onclick : null;
@@ skipping 76 matching lines @@
 
   if (!chrome.experimental)
     chrome.experimental = {};
 
   if (!chrome.experimental.accessibility)
     chrome.experimental.accessibility = {};
 
   if (!chrome.experimental.tts)
     chrome.experimental.tts = {};
 })();