Handle extension webrequest API on the IO thread. This speeds up blocking event

chrome/browser/profiles/profile.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
@@ skipping 63 matching lines @@
 
 using base::Time;
 using base::TimeDelta;
 
 // A pointer to the request context for the default profile.  See comments on
 // Profile::GetDefaultRequestContext.
 net::URLRequestContextGetter* Profile::default_request_context_;
 
 namespace {
 
+static void NotifyOTRProfileCreatedOnIOThread(ProfileId original_profile_id,

[Mihai Parparita -not on Chrome, 2011/06/08 01:11:59]

I thought that using an anonymous namespace was equivalent to the static
keyword, so you wouldn't need it here.

[Matt Perry, 2011/06/08 20:47:00]

Done.

(There's a slight difference, but it doesn't matter here. See
http://groups.google.com/group/comp.lang.c++.moderated/browse_thread/thread/6...
for an explanation.)

+                                              ProfileId otr_profile_id) {
+  ExtensionWebRequestEventRouter::GetInstance()->OnOTRProfileCreated(
+      original_profile_id, otr_profile_id);
+}
+
+static void NotifyOTRProfileDestroyedOnIOThread(ProfileId original_profile_id,
+                                                ProfileId otr_profile_id) {
+  ExtensionWebRequestEventRouter::GetInstance()->OnOTRProfileDestroyed(
+      original_profile_id, otr_profile_id);
+}
+
 }  // namespace
 
 Profile::Profile()
     : restored_last_session_(false),
       accessibility_pause_level_(0) {
 }
 
 // static
 const char* Profile::kProfileKey = "__PROFILE__";
 
@@ skipping 122 matching lines @@
     // getter. chromeos::OnlineAttempt is illegally trying to access this
     // Profile member from a thread other than the UI thread, so we need to
     // prevent a race.
 #if defined(OS_CHROMEOS)
     GetRequestContext();
 #endif  // defined(OS_CHROMEOS)
 
     // Make the chrome//extension-icon/ resource available.
     ExtensionIconSource* icon_source = new ExtensionIconSource(real_profile);
     GetChromeURLDataManager()->AddDataSource(icon_source);
+
+    BrowserThread::PostTask(
+    BrowserThread::IO, FROM_HERE,
+    NewRunnableFunction(
+        &NotifyOTRProfileCreatedOnIOThread,
+        profile_->GetRuntimeId(), reinterpret_cast<ProfileId>(this)));

[Mihai Parparita -not on Chrome, 2011/06/08 01:11:59]

Use GetRuntimeId instead of the cast? I think that should work even though
GetRuntimeId is virtual since it's defined in this class.

[Matt Perry, 2011/06/08 20:47:00]

Done.

   }
 
   virtual ~OffTheRecordProfileImpl() {
     NotificationService::current()->Notify(NotificationType::PROFILE_DESTROYED,
                                            Source<Profile>(this),
                                            NotificationService::NoDetails());
 
     ProfileDependencyManager::GetInstance()->DestroyProfileServices(this);
 
+    BrowserThread::PostTask(
+        BrowserThread::IO, FROM_HERE,
+        NewRunnableFunction(
+            &NotifyOTRProfileDestroyedOnIOThread,
+            profile_->GetRuntimeId(), reinterpret_cast<ProfileId>(this)));

[Mihai Parparita -not on Chrome, 2011/06/08 01:11:59]

Ditto.

[Matt Perry, 2011/06/08 20:47:00]

Done.

+
     // Clean up all DB files/directories
     if (db_tracker_)
       BrowserThread::PostTask(
           BrowserThread::FILE, FROM_HERE,
           NewRunnableMethod(
               db_tracker_.get(),
               &webkit_database::DatabaseTracker::DeleteIncognitoDBDirectory));
 
     BrowserList::RemoveObserver(this);
 
@@ skipping 574 matching lines @@
 };
 #endif
 
 Profile* Profile::CreateOffTheRecordProfile() {
 #if defined(OS_CHROMEOS)
   if (Profile::IsGuestSession())
     return new GuestSessionProfile(this);
 #endif
   return new OffTheRecordProfileImpl(this);
 }