Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: PRESUBMIT.py

Issue 7024048: presubmit: Make AUTHORS presubmit check use lower-cased email addresses. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index f5dd20102302d2e66992ec28fededad1e45b872b..eafb77a1d89ff5783b5c706145cf59657caea1cd 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -105,8 +105,8 @@ def _CheckAuthorizedAuthor(input_api, output_api):
valid_authors = (
input_api.re.match(r'[^#]+\s+\<(.+?)\>\s*$', line)
for line in open(authors_path))
- valid_authors = [item.group(1) for item in valid_authors if item]
- if not author in valid_authors:
+ valid_authors = [item.group(1).lower() for item in valid_authors if item]
+ if not author.lower() in valid_authors:
return [output_api.PresubmitPromptWarning(
('%s is not in AUTHORS file. If you are a new contributor, please visit'
'\n'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698