Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Issue 7024043: Disable RegisterProtocolHandler on Linux. (Closed)

Created:
9 years, 6 months ago by koz (OOO until 15th September)
Modified:
9 years, 5 months ago
Reviewers:
tony, laforge, benwells, tc
CC:
chromium-reviews
Visibility:
Public.

Description

Disable RegisterProtocolHandler on Linux. The OS-level registration isn't implemented on Linux, and so every time the browser starts it will act as though another program has been registered to handle the protocols it knows about and deregister them all internally. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88246

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M build/common.gypi View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
koz (OOO until 15th September)
Hey Tony, This needs to go in to the branch for M13, could you tell ...
9 years, 6 months ago (2011-06-06 06:42:05 UTC) #1
koz (OOO until 15th September)
9 years, 6 months ago (2011-06-06 06:43:54 UTC) #2
koz (OOO until 15th September)
Oh, never mind - I figured it out :-)
9 years, 6 months ago (2011-06-06 07:01:57 UTC) #3
tony
This will disable it on ChromeOS too. Is that what we want? Ideally on ChromeOS ...
9 years, 6 months ago (2011-06-06 16:48:17 UTC) #4
koz (OOO until 15th September)
Ah okay. I think it should be okay to disable on ChromeOS, as they seem ...
9 years, 6 months ago (2011-06-07 07:51:58 UTC) #5
benwells
We should probably aim to turn it on in ChromeOS so we can support other ...
9 years, 6 months ago (2011-06-07 10:24:04 UTC) #6
benwells
> Looking at the settings pages on ChromeOS > they seem to be a bit ...
9 years, 6 months ago (2011-06-07 11:03:15 UTC) #7
laforge
Time is off the essence on m13, please close this out. On 2011/06/07 11:03:15, benwells ...
9 years, 6 months ago (2011-06-07 19:13:39 UTC) #8
tony
9 years, 6 months ago (2011-06-07 19:19:49 UTC) #9
Since ChromeOS already has a way to handle mailto, this change seems OK, but
suboptimal.  LGTM.

However, I would rather we just never deregister on Linux except via the options
dialog.

Powered by Google App Engine
This is Rietveld 408576698