Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 7024041: MIPS: port Implement set trap for proxies, and revamp class hierarchy in preparation (Closed)

Created:
9 years, 6 months ago by Paul Lind
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: port Implement set trap for proxies, and revamp class hierarchy in preparation Ported commits: r8126 (6461bae) Original commit message: - Introduce a class JSReceiver, that is a common superclass of JSObject and JSProxy. Use JSReceiver where appropriate (probably lots of places that we still have to migrate, but we will find those later with proxy test suite). - Move appropriate methods to JSReceiver class (SetProperty, GetPropertyAttribute, Get/SetPrototype, Lookup, and so on). - Introduce new JSFunctionProxy subclass of JSProxy. Currently only a stub. - Overhaul enum InstanceType: * Introduce FIRST/LAST_SPEC_OBJECT_TYPE that ranges over all types that represent JS objects, and use that consistently to check language types. * Rename FIRST/LAST_JS_OBJECT_TYPE and FIRST/LAST_FUNCTION_CLASS_TYPE to FIRST/LAST_[NON]CALLABLE_SPEC_OBJECT_TYPE for clarity. * Eliminate the overlap over JS_REGEXP_TYPE. * Also replace FIRST_JS_OBJECT with FIRST_JS_RECEIVER, but only use it where we exclusively talk about the internal representation type. * Insert JS_PROXY and JS_FUNCTION_PROXY in the appropriate places. - Fix all checks concerning classification, especially for functions, to use the CALLABLE_SPEC_OBJECT range (that includes funciton proxies). - Handle proxies in SetProperty (that was the easiest part :) ). - A few simple test cases. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8175

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -39 lines) Patch
M src/mips/builtins-mips.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 6 chunks +15 lines, -14 lines 1 comment Download
M src/mips/ic-mips.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Lind
9 years, 6 months ago (2011-06-06 05:46:02 UTC) #1
Mads Ager (chromium)
9 years, 6 months ago (2011-06-06 08:44:20 UTC) #2
LGTM. I will address nit and land.

http://codereview.chromium.org/7024041/diff/1/src/mips/full-codegen-mips.cc
File src/mips/full-codegen-mips.cc (right):

http://codereview.chromium.org/7024041/diff/1/src/mips/full-codegen-mips.cc#n...
src/mips/full-codegen-mips.cc:2482: Split(le, a1,
Operand(LAST_NONCALLABLE_SPEC_OBJECT_TYPE), if_true, if_false, fall_through);
Line too long.

Powered by Google App Engine
This is Rietveld 408576698