Issue 7024034: Add ben as an owner in chrome\browser\renderer_host. Before you were in chrome\browser\OWNERS, b...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7024034: Add ben as an owner in chrome\browser\renderer_host. Before you were in chrome\browser\OWNERS, b... (Closed)

Created:
9 years, 6 months ago by jam

Modified:
9 years, 6 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add ben and sky as an owner in chrome\browser\renderer_host and add sky to content\browser\OWNERS. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88480

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/browser/renderer_host/OWNERS	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
	M	content/browser/OWNERS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

9 years, 6 months ago (2011-06-09 01:54:29 UTC) #3

LGTM

On Fri, Jun 3, 2011 at 4:34 PM, <jam@chromium.org> wrote:

> Reviewers: Ben Goodger,
>
> Description:
> Add ben as an owner in chrome\browser\renderer_host.  Before you were in
> chrome\browser\OWNERS, but now that it's gone, we need more owners here.
>
> Please review this at http://codereview.chromium.org/7024034/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/renderer_host/OWNERS
>
>
> Index: chrome/browser/renderer_host/OWNERS
> ===================================================================
> --- chrome/browser/renderer_host/OWNERS (revision 87866)
> +++ chrome/browser/renderer_host/OWNERS (working copy)
> @@ -1,2 +1,3 @@
> +ben@chromium.org
> +brettw@chromium.org
>  jam@chromium.org
> -brettw@chromium.org
>
>
>

Expand Messages | Collapse Messages