Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8584)

Unified Diff: chrome/browser/ui/views/keyboard_overlay_dialog_view.cc

Issue 7024032: Wait showing html dialog until renderer finish painting after page is loaded. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix clang error Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/keyboard_overlay_dialog_view.h ('k') | views/widget/native_widget_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/keyboard_overlay_dialog_view.cc
diff --git a/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc b/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc
index 7da848c78e7c6b42e0ce9c88d2fb8aab054b7d77..bfdb86aeeff3e8ef82a2a7d1843ad8633cd22947 100644
--- a/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc
+++ b/chrome/browser/ui/views/keyboard_overlay_dialog_view.cc
@@ -44,16 +44,7 @@ KeyboardOverlayDialogView::KeyboardOverlayDialogView(
KeyboardOverlayDialogView::~KeyboardOverlayDialogView() {
}
-void KeyboardOverlayDialogView::InitDialog() {
- DOMView::Init(profile(), NULL);
-
- tab_contents_->set_delegate(this);
-
- // Set the delegate. This must be done before loading the page. See
- // the comment above HtmlDialogUI in its header file for why.
- HtmlDialogUI::GetPropertyAccessor().SetProperty(tab_contents_->property_bag(),
- this);
-
+void KeyboardOverlayDialogView::RegisterDialogAccelerators() {
for (size_t i = 0; i < arraysize(kCloseAccelerators); ++i) {
views::Accelerator accelerator(kCloseAccelerators[i].keycode,
kCloseAccelerators[i].shift_pressed,
@@ -78,8 +69,6 @@ void KeyboardOverlayDialogView::InitDialog() {
}
AddAccelerator(accelerator);
}
-
- DOMView::LoadURL(GetDialogContentURL());
}
bool KeyboardOverlayDialogView::AcceleratorPressed(
« no previous file with comments | « chrome/browser/ui/views/keyboard_overlay_dialog_view.h ('k') | views/widget/native_widget_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698