Wait showing html dialog until renderer finish painting after page is loaded.

chrome/browser/ui/views/html_dialog_view_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/ui/ui_test.h"
 
 #include "base/file_path.h"
 #include "base/memory/singleton.h"
 #include "base/message_loop.h"
 #include "chrome/browser/ui/views/html_dialog_view.h"
@@ skipping 24 matching lines @@
   virtual ~TestHtmlDialogUIDelegate() {}
 
   // HTMLDialogUIDelegate implementation:
   virtual bool IsDialogModal() const {
     return true;
   }
   virtual std::wstring GetDialogTitle() const {
     return std::wstring(L"Test");
   }
   virtual GURL GetDialogContentURL() const {
-    return GURL(chrome::kAboutBlankURL);
+    return GURL(chrome::kAboutAboutURL);

[oshima, 2011/06/07 19:10:09]

this has to be some real page so that it gets painted after load.

   }
   virtual void GetWebUIMessageHandlers(
       std::vector<WebUIMessageHandler*>* handlers) const { }
   virtual void GetDialogSize(gfx::Size* size) const {
     size->set_width(40);
     size->set_height(40);
   }
   virtual std::string GetDialogArgs() const {
     return std::string();
   }
@@ skipping 142 matching lines @@
 
   html_view->MoveContents(tab_contents, set_bounds);
   ui_test_utils::RunMessageLoop();
   actual_bounds = html_view->GetWidget()->GetClientAreaScreenBounds();
   EXPECT_LT(0, actual_bounds.width());
   EXPECT_LT(0, actual_bounds.height());
 
   MessageLoopForUI::current()->RemoveObserver(
       WindowChangedObserver::GetInstance());
 }
+
+IN_PROC_BROWSER_TEST_F(HtmlDialogBrowserTest, TestStateTransition) {
+  HtmlDialogUIDelegate* delegate = new TestHtmlDialogUIDelegate();
+
+  HtmlDialogView* html_view =
+      new HtmlDialogView(browser()->profile(), delegate);
+  TabContents* tab_contents = browser()->GetSelectedTabContents();
+  ASSERT_TRUE(tab_contents != NULL);
+  views::Window::CreateChromeWindow(tab_contents->GetMessageBoxRootWindow(),
+                                    gfx::Rect(), html_view);
+  // Test if the state transitions INITIALIZED -> LOADED -> PAINTED in this
+  // order.
+  EXPECT_EQ(HtmlDialogView::INITIALIZED, html_view->state_);
+
+  html_view->InitDialog();
+  html_view->window()->Show();
+
+  MessageLoopForUI::current()->AddObserver(
+      WindowChangedObserver::GetInstance());
+  // We use busy loop because the state is updated in notifications.
+  while (html_view->state_ == HtmlDialogView::INITIALIZED)
+    MessageLoop::current()->RunAllPending();
+  EXPECT_EQ(HtmlDialogView::LOADED, html_view->state_);
+
+  while (html_view->state_ == HtmlDialogView::LOADED)
+    MessageLoop::current()->RunAllPending();
+
+  EXPECT_EQ(HtmlDialogView::PAINTED, html_view->state_);
+
+  MessageLoopForUI::current()->RemoveObserver(
+      WindowChangedObserver::GetInstance());
+}