Issue 7024028: Remove canvas throttling in GLES2Implementation::CopyTextureToParentTexture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7024028: Remove canvas throttling in GLES2Implementation::CopyTextureToParentTexture. (Closed)

Created:
9 years, 6 months ago by jbates

Modified:
9 years, 6 months ago

Reviewers:
jamesr, nduca, apatrick_chromium

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove canvas throttling in GLES2Implementation::CopyTextureToParentTexture. BUG=83628 TEST=run FishIE demo, verify that FlushSync is not called multiple times every frame during DoDeferredUpdate Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87876

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	gpu/command_buffer/client/gles2_implementation.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nduca

I'm a bit concerned that this leaves us in a state where settimeout canvas2d drawing ...

9 years, 6 months ago (2011-06-06 16:42:04 UTC) #3

jbates

9 years, 6 months ago (2011-06-06 16:51:55 UTC) #4

On 2011/06/06 16:42:04, nduca wrote:
> I'm a bit concerned that this leaves us in a state where settimeout canvas2d
> drawing could perpetually beat the compositor and lead to decaying framerates.
> Any idea if that's happening or if not, why not?

Indeed it does. I wouldn't necessarily drover this patch to 13. You are cc'd on
the bug regarding this problem:
http://code.google.com/p/chromium/issues/detail?id=84781

Expand Messages | Collapse Messages