Clean up video frame sizes, types in Video Decode API

media/video/picture.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_VIDEO_PICTURE_H_
 #define MEDIA_VIDEO_PICTURE_H_
 
 #include "base/basictypes.h"
 #include "ui/gfx/size.h"
 
@@ skipping 75 matching lines @@
 
  private:
   void* data_;
   BufferInfo info_;
 };
 
 // A decoded picture frame.
 // This is the media-namespace equivalent of PP_Picture_Dev.
 class Picture {
  public:
-  Picture(int32 picture_buffer_id, int32 bitstream_buffer_id,
-          gfx::Size visible_size, gfx::Size decoded_size);
+  Picture(int32 picture_buffer_id, int32 bitstream_buffer_id);
   Picture(const PP_Picture_Dev& picture);
 
   // Returns the id of the picture buffer where this picture is contained.
   int32 picture_buffer_id() const {
     return picture_buffer_id_;
   }
 
   // Returns the id of the bitstream buffer from which this frame was decoded.
   // TODO(vrk): Handle the case where a picture can span multiple buffers.
   int32 bitstream_buffer_id() const {
     return bitstream_buffer_id_;
   }
 
-  // Returns the visible size of the decoded picture in pixels.
-  gfx::Size visible_size() const {
-    return visible_size_;
-  }
-
-  // Returns the decoded size of the decoded picture in pixels.
-  gfx::Size decoded_size() const {
-    return decoded_size_;
-  }
-
  private:
   int32 picture_buffer_id_;
   int32 bitstream_buffer_id_;
-  gfx::Size visible_size_;
-  gfx::Size decoded_size_;

[Ville-Mikko Rautio, 2011/05/17 08:58:49]

After removing these how do we plan to handle situation where the picture size
changes due to in-band signalling in video bitstream? This means a case where
application does not see the change in picture parameters, only the decoder gets
to know about it through decoding the input video bitstream with new parameters.

This is valid use case in most modern video coding standards, including H.264
and VP8.

[vrk (LEFT CHROMIUM), 2011/05/23 18:20:29]

If the decoded picture size changes, the decoder will dismiss the currently
assigned picture buffers and will request new picture buffers of the proper
size.

The output size is still always determined by the client.

 };
 
 }  // namespace media
 
 #endif  // MEDIA_VIDEO_PICTURE_H_