Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 7020035: Make git-cl and update_depot_tools msys-compatible. (Closed)

Created:
9 years, 6 months ago by cmp
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Make git-cl and update_depot_tools msys-compatible. This change makes it possible to run 'git cl' from a Command Prompt using only the auto-installed git from depot_tools. It is needed because in MSysGit, 'git cl' invokes 'git' which calls 'git-cl'. While 'git-cl' is pulled from depot_tools (since it's in PATH), depot_tools/python_bin is not in PATH, and so we execute git_cl.py through our auto-installed python.exe directly. update_depot_tools is fixed so that if we find the auto-installed svn and git in depot_tools, we execute those directly, otherwise falling back to calling them based on PATH. In both git-cl and update_depot_tools, we only enable this new behavior if uname in PATH reports a 'MINGW' environment. This should not trigger on any other environment where uname exists, including Cygwin which should report 'CYGWIN'. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87510

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -8 lines) Patch
M git-cl View 2 chunks +12 lines, -2 lines 0 comments Download
M update_depot_tools View 6 chunks +21 lines, -6 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
cmp
I plan to land this again today. Will stay alert for reports of trouble.
9 years, 6 months ago (2011-06-01 18:32:34 UTC) #1
nsylvain
LGTM
9 years, 6 months ago (2011-06-01 18:51:22 UTC) #2
M-A Ruel
9 years, 6 months ago (2011-06-01 18:52:28 UTC) #3
lgtm with cleanup

http://codereview.chromium.org/7020035/diff/1/update_depot_tools
File update_depot_tools (right):

http://codereview.chromium.org/7020035/diff/1/update_depot_tools#newcode36
update_depot_tools:36: function test_git {
Oh BTW, () is missing here and on line 51. But in any case test_git is not used
at all.

Powered by Google App Engine
This is Rietveld 408576698