Made ENABLE_TOUCH_ICON_LOADING configurable.

Made ENABLE_TOUCH_ICON_LOADING configurable.


BUG=71571
TEST=Existing tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87720

[michaelbai, 2011-06-01 18:33:21]

Please help to review it

[Emmanuel Saint-loubert-Bié, 2011-06-02 17:13:30]

Hi Michael, I talked to other team members and they would prefer that we do not
introduce another variable, and instead do 
'ENABLE_TOUCH_ICON_LOADING=<(touchui)'

[Emmanuel Saint-loubert-Bié, 2011-06-02 17:25:46]

OK I was mistaken, what we need to do is
   if(touchui) => enable_touch_icon_loading = 1
somewhere in that file (since the converse is not necessarily true)

Michael: either you do this or I do it after this has landed. Thanks!

[Emmanuel Saint-loubert-Bié, 2011-06-02 20:15:42]

This is the patch that works on top of your CL and which I tested, so unless
Darin has to sign0-off too it certainly LGTM
===================================================

diff --git a/build/features_override.gypi b/build/features_override.gypi
index 965171f..969b5ea 100644
--- a/build/features_override.gypi
+++ b/build/features_override.gypi
@@ -107,6 +107,9 @@
         ],
         'use_threaded_compositing': 1,
       }],
+      ['touchui==1', {
+        'enable_touch_icon_loading': 1,
+      }],
       # TODO(crogers): For the moment Windows is only enabled for
       # Google-branded build, since the FFmpeg DLLs need to be re-built
       # for chromium.

[darin (slow to review), 2011-06-02 23:04:46]

OK, LGTM