Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 7020031: [Sync] Move chrome/browser/sync/api files into their own targets (Closed)

Created:
9 years, 6 months ago by akalin
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[Sync] Move chrome/browser/sync/api files into their own targets New target is 'syncapi_service'. Rename existing 'syncapi' target to 'syncapi_core'. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87666

Patch Set 1 #

Patch Set 2 : Sync to head #

Patch Set 3 : Fix chrome_frame gyp error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -23 lines) Patch
M chrome/chrome.gyp View 3 chunks +34 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +3 lines, -9 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 8 chunks +27 lines, -9 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
akalin
+tim for review
9 years, 6 months ago (2011-06-01 17:37:45 UTC) #1
akalin
On 2011/06/01 17:37:45, akalin wrote: > +tim for review Ping!
9 years, 6 months ago (2011-06-02 17:07:05 UTC) #2
tim (not reviewing)
LGTM! I like your choice of names way better than what I came up with ...
9 years, 6 months ago (2011-06-02 17:14:43 UTC) #3
commit-bot: I haz the power
Try job failure for 7020031-1 on win for step update: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=35029
9 years, 6 months ago (2011-06-02 18:45:25 UTC) #4
commit-bot: I haz the power
Try job failure for 7020031-5001 on win for step update: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=35035
9 years, 6 months ago (2011-06-02 18:55:57 UTC) #5
commit-bot: I haz the power
9 years, 6 months ago (2011-06-02 20:07:35 UTC) #6
Change committed as 87666

Powered by Google App Engine
This is Rietveld 408576698