Lower heap size limits on systems that are short of virtual memory.

Lower heap size limits on systems that are short of virtual memory.
Committed: http://code.google.com/p/v8/source/detail?r=8133

[Kasper Lund, 2011-06-01 08:23:49]

http://codereview.chromium.org/7020020/diff/1/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/7020020/diff/1/src/heap.cc#newcode158
src/heap.cc:158: if (code_range_size_ > 0) {
It would be nice with a comment here that explains how the max virtual memory is
carved up. It's not completely clear why you use 1/4 on code and 1/2 on old gen
(what do you use the last 1/4 on)? If code_range_size_ == 0 why don't you want
to use the same fraction of max_virtual?

[Kasper Lund, 2011-06-01 08:46:04]

LGTM.

http://codereview.chromium.org/7020020/diff/4002/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/7020020/diff/4002/src/heap.cc#newcode162
src/heap.cc:162: if (code_range_size_ > 0) {
Maybe introduce two local variables, half and quarter, and use them instead of
the repeated max_virtual >> {1,2}.