Issue 7019039: [cros] Move carrier deal shown property to LocalState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7019039: [cros] Move carrier deal shown property to LocalState. (Closed)

Created:
9 years, 7 months ago by Nikita (slow)

Modified:
9 years, 7 months ago

Reviewers:
Dmitry Polukhin

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[cros] Move carrier deal shown property to LocalState. BUG=chromium-os:15631 TEST=Manual. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86413

Patch Set 2 : ws & merge #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -28 lines)			Patch
M	chrome/browser/chromeos/preferences.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu_button.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu_button.cc	View	1	4 chunks	+14 lines, -17 lines	0 comments	Download
M	chrome/browser/prefs/browser_prefs.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/pref_names.cc	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dmitry Polukhin

LGTM http://codereview.chromium.org/7019039/diff/1/chrome/browser/chromeos/status/network_menu_button.cc File chrome/browser/chromeos/status/network_menu_button.cc (right): http://codereview.chromium.org/7019039/diff/1/chrome/browser/chromeos/status/network_menu_button.cc#newcode79 chrome/browser/chromeos/status/network_menu_button.cc:79: // Returns prefs::kCarrierDealPromoShown which is number of times ...

9 years, 7 months ago (2011-05-23 12:46:59 UTC) #2

Nikita (slow)

9 years, 7 months ago (2011-05-24 08:22:53 UTC) #3

http://codereview.chromium.org/7019039/diff/1/chrome/browser/chromeos/status/...
File chrome/browser/chromeos/status/network_menu_button.cc (right):

http://codereview.chromium.org/7019039/diff/1/chrome/browser/chromeos/status/...
chrome/browser/chromeos/status/network_menu_button.cc:79: // Returns
prefs::kCarrierDealPromoShown which is number of times
On 2011/05/23 12:46:59, Dmitry Polukhin wrote:
> Please add empty line above the comment.

Done.

Expand Messages | Collapse Messages

Issue 7019039: [cros] Move carrier deal shown property to LocalState. (Closed)

Description

Patch Set 1 #

Patch Set 2 : ws & merge #

Messages