Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 7019015: Revert 85646 - Adds support for the DHCP portion of the WPAD (proxy auto-discovery) protocol. (Closed)

Created:
9 years, 7 months ago by Jói
Modified:
9 years, 7 months ago
Reviewers:
Jói
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, mmenke, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 85646 - Adds support for the DHCP portion of the WPAD (proxy auto-discovery) protocol. This is Windows-only for now, and is disabled by default. Start Chrome with the flag --enable-dhcp-wpad to enable the feature. See discussion in comment on DhcpProxyScriptFetcherFactory for why this needs to be done in a per-platform way rather than cross-platform. The code is factored so that adding other platform implementations will be straight forward. Most of the implementation is stand-alone and extends the ScriptProxyFetcher class hierarchy (and makes its interface slightly more generic). The integration point into existing code is in InitProxyResolver, which previously handled fallback from DNS auto-detect to custom PAC URL and now does fallback from DHCP to DNS to custom PAC URL. BUG=18575 TEST=net_unittests has good coverage for the new and changed code, but manual tests on a network with a PAC URL configured in DHCP are also needed. Review URL: http://codereview.chromium.org/6831025 TBR=joi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85648

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -2524 lines) Patch
M chrome/browser/net/connection_tester.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/net/proxy_service_factory.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/base/net_error_list.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/base/net_log_event_type_list.h View 4 chunks +7 lines, -7 lines 0 comments Download
M net/net.gyp View 3 chunks +0 lines, -15 lines 0 comments Download
D net/proxy/dhcp_proxy_script_adapter_fetcher_win.h View 1 chunk +0 lines, -198 lines 0 comments Download
D net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc View 1 chunk +0 lines, -286 lines 0 comments Download
D net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc View 1 chunk +0 lines, -300 lines 0 comments Download
D net/proxy/dhcp_proxy_script_fetcher.h View 1 chunk +0 lines, -98 lines 0 comments Download
D net/proxy/dhcp_proxy_script_fetcher.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D net/proxy/dhcp_proxy_script_fetcher_factory.h View 1 chunk +0 lines, -68 lines 0 comments Download
D net/proxy/dhcp_proxy_script_fetcher_factory.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D net/proxy/dhcp_proxy_script_fetcher_win.h View 1 chunk +0 lines, -123 lines 0 comments Download
D net/proxy/dhcp_proxy_script_fetcher_win.cc View 1 chunk +0 lines, -246 lines 0 comments Download
D net/proxy/dhcp_proxy_script_fetcher_win_unittest.cc View 1 chunk +0 lines, -545 lines 0 comments Download
D net/proxy/dhcpcsvc_init_win.h View 1 chunk +0 lines, -20 lines 0 comments Download
D net/proxy/dhcpcsvc_init_win.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M net/proxy/init_proxy_resolver.h View 7 chunks +14 lines, -32 lines 0 comments Download
M net/proxy/init_proxy_resolver.cc View 10 chunks +42 lines, -103 lines 0 comments Download
M net/proxy/init_proxy_resolver_unittest.cc View 27 chunks +30 lines, -156 lines 0 comments Download
D net/proxy/mock_proxy_script_fetcher.h View 1 chunk +0 lines, -44 lines 0 comments Download
D net/proxy/mock_proxy_script_fetcher.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M net/proxy/proxy_script_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_script_fetcher_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_service.h View 5 chunks +4 lines, -17 lines 0 comments Download
M net/proxy/proxy_service.cc View 5 chunks +5 lines, -13 lines 0 comments Download
M net/proxy/proxy_service_unittest.cc View 13 chunks +58 lines, -24 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Jói
9 years, 7 months ago (2011-05-17 17:55:01 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698