Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2012)

Unified Diff: skia/ext/platform_canvas_unittest.cc

Issue 7019013: Removal of dependencies on PlatformDevice classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Remove PlatformCanvas::getTopDevice. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: skia/ext/platform_canvas_unittest.cc
===================================================================
--- skia/ext/platform_canvas_unittest.cc (revision 86430)
+++ skia/ext/platform_canvas_unittest.cc (working copy)
@@ -31,8 +31,8 @@
bool VerifyRect(const PlatformCanvas& canvas,
uint32_t canvas_color, uint32_t rect_color,
int x, int y, int w, int h) {
- PlatformDevice& device = canvas.getTopPlatformDevice();
- const SkBitmap& bitmap = device.accessBitmap(false);
+ SkDevice* device = skia::GetTopDevice(&canvas);
+ const SkBitmap& bitmap = device->accessBitmap(false);
SkAutoLockPixels lock(bitmap);
// For masking out the alpha values.
@@ -70,8 +70,8 @@
bool VerifyRoundedRect(const PlatformCanvas& canvas,
uint32_t canvas_color, uint32_t rect_color,
int x, int y, int w, int h) {
- PlatformDevice& device = canvas.getTopPlatformDevice();
- const SkBitmap& bitmap = device.accessBitmap(false);
+ SkDevice* device = skia::GetTopDevice(&canvas);
+ const SkBitmap& bitmap = device->accessBitmap(false);
SkAutoLockPixels lock(bitmap);
// Check corner points first. They should be of canvas_color.
@@ -103,7 +103,8 @@
#if defined(OS_WIN)
void DrawNativeRect(PlatformCanvas& canvas, int x, int y, int w, int h) {
- HDC dc = canvas.beginPlatformPaint();
+ skia::ScopedPlatformPaint scoped_platform_paint(&canvas);
+ HDC dc = scoped_platform_paint.GetPlatformSurface();
RECT inner_rc;
inner_rc.left = x;
@@ -111,21 +112,18 @@
inner_rc.right = x + w;
inner_rc.bottom = y + h;
FillRect(dc, &inner_rc, reinterpret_cast<HBRUSH>(GetStockObject(BLACK_BRUSH)));
-
- canvas.endPlatformPaint();
}
#elif defined(OS_MACOSX)
void DrawNativeRect(PlatformCanvas& canvas, int x, int y, int w, int h) {
- CGContextRef context = canvas.beginPlatformPaint();
-
+ skia::ScopedPlatformPaint scoped_platform_paint(&canvas);
+ CGContextRef context = scoped_platform_paint.GetPlatformSurface();
+
CGRect inner_rc = CGRectMake(x, y, w, h);
// RGBA opaque black
CGColorRef black = CGColorCreateGenericRGB(0.0, 0.0, 0.0, 1.0);
CGContextSetFillColorWithColor(context, black);
CGColorRelease(black);
CGContextFillRect(context, inner_rc);
-
- canvas.endPlatformPaint();
}
#else
void DrawNativeRect(PlatformCanvas& canvas, int x, int y, int w, int h) {
@@ -244,7 +242,7 @@
LayerSaver layer(canvas, kLayerX, kLayerY, kLayerW, kLayerH);
DrawNativeRect(canvas, 0, 0, 100, 100);
#if defined(OS_WIN)
- canvas.getTopPlatformDevice().makeOpaque(0, 0, 100, 100);
+ MakeOpaque(&canvas, 0, 0, 100, 100);
#endif
}
EXPECT_TRUE(VerifyBlackRect(canvas, kLayerX, kLayerY, kLayerW, kLayerH));
@@ -255,8 +253,7 @@
LayerSaver layer(canvas, kLayerX, kLayerY, kLayerW, kLayerH);
DrawNativeRect(canvas, kInnerX, kInnerY, kInnerW, kInnerH);
#if defined(OS_WIN)
- canvas.getTopPlatformDevice().makeOpaque(kInnerX, kInnerY,
- kInnerW, kInnerH);
+ MakeOpaque(&canvas, kInnerX, kInnerY, kInnerW, kInnerH);
#endif
}
EXPECT_TRUE(VerifyBlackRect(canvas, kInnerX, kInnerY, kInnerW, kInnerH));
@@ -269,8 +266,7 @@
AddClip(canvas, kInnerX, kInnerY, kInnerW, kInnerH);
DrawNativeRect(canvas, 0, 0, 100, 100);
#if defined(OS_WIN)
- canvas.getTopPlatformDevice().makeOpaque(
- kInnerX, kInnerY, kInnerW, kInnerH);
+ MakeOpaque(&canvas, kInnerX, kInnerY, kInnerW, kInnerH);
#endif
canvas.restore();
}
@@ -284,7 +280,7 @@
LayerSaver layer(canvas, kLayerX, kLayerY, kLayerW, kLayerH);
DrawNativeRect(canvas, 0, 0, 100, 100);
#if defined(OS_WIN)
- canvas.getTopPlatformDevice().makeOpaque(0, 0, 100, 100);
+ MakeOpaque(&canvas, 0, 0, 100, 100);
#endif
}
canvas.restore();
@@ -305,7 +301,7 @@
LayerSaver layer(canvas, kLayerX, kLayerY, kLayerW, kLayerH);
DrawNativeRect(canvas, 0, 0, 100, 100);
#if defined(OS_WIN)
- canvas.getTopPlatformDevice().makeOpaque(0, 0, 100, 100);
+ MakeOpaque(&canvas, 0, 0, 100, 100);
#endif
}
canvas.restore();
@@ -320,8 +316,7 @@
LayerSaver layer(canvas, kLayerX, kLayerY, kLayerW, kLayerH);
DrawNativeRect(canvas, kInnerX, kInnerY, kInnerW, kInnerH);
#if defined(OS_WIN)
- canvas.getTopPlatformDevice().makeOpaque(kInnerX, kInnerY,
- kInnerW, kInnerH);
+ MakeOpaque(&canvas, kInnerX, kInnerY, kInnerW, kInnerH);
#endif
}
canvas.restore();
@@ -336,8 +331,7 @@
canvas.translate(1, 1);
DrawNativeRect(canvas, kInnerX, kInnerY, kInnerW, kInnerH);
#if defined(OS_WIN)
- canvas.getTopPlatformDevice().makeOpaque(kInnerX, kInnerY,
- kInnerW, kInnerH);
+ MakeOpaque(&canvas, kInnerX, kInnerY, kInnerW, kInnerH);
#endif
}
canvas.restore();
@@ -355,8 +349,7 @@
AddClip(canvas, kInnerX + 1, kInnerY + 1, kInnerW - 1, kInnerH - 1);
DrawNativeRect(canvas, 0, 0, 100, 100);
#if defined(OS_WIN)
- canvas.getTopPlatformDevice().makeOpaque(kLayerX, kLayerY,
- kLayerW, kLayerH);
+ MakeOpaque(&canvas, kLayerX, kLayerY, kLayerW, kLayerH);
#endif
}
canvas.restore();
@@ -384,8 +377,7 @@
DrawNativeRect(canvas, 0, 0, 100, 100);
#if defined(OS_WIN)
- canvas.getTopPlatformDevice().makeOpaque(kLayerX, kLayerY,
- kLayerW, kLayerH);
+ MakeOpaque(&canvas, kLayerX, kLayerY, kLayerW, kLayerH);
#endif
}
canvas.restore();

Powered by Google App Engine
This is Rietveld 408576698