Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: skia/ext/platform_canvas.cc

Issue 7019013: Removal of dependencies on PlatformDevice classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Remove PlatformCanvas::getTopDevice. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: skia/ext/platform_canvas.cc
===================================================================
--- skia/ext/platform_canvas.cc (revision 86430)
+++ skia/ext/platform_canvas.cc (working copy)
@@ -7,14 +7,6 @@
#include "skia/ext/bitmap_platform_device.h"
#include "third_party/skia/include/core/SkTypes.h"
-namespace {
-skia::PlatformDevice* GetTopPlatformDevice(const SkCanvas* canvas) {
- // All of our devices should be our special PlatformDevice.
- SkCanvas::LayerIter iter(const_cast<SkCanvas*>(canvas), false);
- return static_cast<skia::PlatformDevice*>(iter.device());
-}
-}
-
namespace skia {
PlatformCanvas::PlatformCanvas() {
@@ -29,10 +21,6 @@
return NULL;
}
-PlatformDevice& PlatformCanvas::getTopPlatformDevice() const {
- return *GetTopPlatformDevice(this);
-}
-
// static
size_t PlatformCanvas::StrideForWidth(unsigned width) {
return 4 * width;
@@ -51,18 +39,32 @@
return new PlatformCanvas(width, height, is_opaque);
}
+SkDevice* GetTopDevice(const SkCanvas* canvas) {
+ SkCanvas::LayerIter iter(const_cast<SkCanvas*>(canvas), false);
+ return iter.device();
+}
+
bool SupportsPlatformPaint(const SkCanvas* canvas) {
- // TODO(alokp): Rename PlatformDevice::IsNativeFontRenderingAllowed after
- // removing these calls from WebKit.
- return GetTopPlatformDevice(canvas)->IsNativeFontRenderingAllowed();
+ // TODO(alokp): Rename IsNativeFontRenderingAllowed after removing these
+ // calls from WebKit.
+ return IsNativeFontRenderingAllowed(GetTopDevice(canvas));
}
-PlatformDevice::PlatformSurface BeginPlatformPaint(SkCanvas* canvas) {
- return GetTopPlatformDevice(canvas)->BeginPlatformPaint();
+PlatformSurface BeginPlatformPaint(SkCanvas* canvas) {
+ return BeginPlatformPaint(GetTopDevice(canvas));
}
void EndPlatformPaint(SkCanvas* canvas) {
- GetTopPlatformDevice(canvas)->EndPlatformPaint();
+ EndPlatformPaint(GetTopDevice(canvas));
}
+void DrawToNativeContext(SkCanvas* canvas, PlatformSurface context, int x,
+ int y, const PlatformRect* src_rect) {
+ DrawToNativeContext(GetTopDevice(canvas), context, x, y, src_rect);
+}
+
+void MakeOpaque(SkCanvas* canvas, int x, int y, int width, int height) {
+ MakeOpaque(GetTopDevice(canvas), x, y, width, height);
+}
+
} // namespace skia

Powered by Google App Engine
This is Rietveld 408576698