Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 7019010: Fix bug restoring of JS entry sp so to fix profiler-related valgrind issues. (Closed)

Created:
9 years, 7 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix bug restoring of JS entry sp so to fix profiler-related valgrind issues. The profiler did not correctly identify when there was a JS frame on the stack after an exception was thrown. I also refactored the code to use PopTryHandler macro-instructions on all platforms BUG=73722 TEST=No more valgrind errors related to v8::internal::StackFrameIterator. Committed: http://code.google.com/p/v8/source/detail?r=7910

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : refactored ARM to use PopTryHandler macro-instruction #

Total comments: 6

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -38 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 2 chunks +22 lines, -18 lines 0 comments Download
M src/frames.h View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 2 chunks +10 lines, -9 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
9 years, 7 months ago (2011-05-17 10:24:51 UTC) #1
Vyacheslav Egorov (Chromium)
LGTM http://codereview.chromium.org/7019010/diff/7/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/7019010/diff/7/src/arm/code-stubs-arm.cc#newcode3578 src/arm/code-stubs-arm.cc:3578: __ mov(ip, Operand(Smi::FromInt(StackFrame::INNER_JS)));; remove extra ; http://codereview.chromium.org/7019010/diff/7/src/frames.h File ...
9 years, 7 months ago (2011-05-17 10:54:05 UTC) #2
fschneider
9 years, 7 months ago (2011-05-17 11:09:17 UTC) #3
http://codereview.chromium.org/7019010/diff/7/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/7019010/diff/7/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:3578: __ mov(ip,
Operand(Smi::FromInt(StackFrame::INNER_JS)));;
On 2011/05/17 10:54:05, Vyacheslav Egorov wrote:
> remove extra ;

Done.

http://codereview.chromium.org/7019010/diff/7/src/frames.h
File src/frames.h (right):

http://codereview.chromium.org/7019010/diff/7/src/frames.h#newcode155
src/frames.h:155: // Used to mark the outermost JS frame.
On 2011/05/17 10:54:05, Vyacheslav Egorov wrote:
> outermost JS entry frame

Done.

http://codereview.chromium.org/7019010/diff/7/src/frames.h#newcode157
src/frames.h:157: INNER_JS = 0,
On 2011/05/17 10:54:05, Vyacheslav Egorov wrote:
> INNER_JSENTRY_FRAME, OUTERMOST_JSENTRY_FRAME?

Done.

Powered by Google App Engine
This is Rietveld 408576698