Issue 7018001: Micro-optimize passing of args to HasLocalProperty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7018001: Micro-optimize passing of args to HasLocalProperty. (Closed)

Created:
9 years, 7 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Micro-optimize passing of args to HasLocalProperty. Committed: http://code.google.com/p/v8/source/detail?r=7878

Patch Set 1 #

Total comments: 2

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/macros.py	View		1 chunk	+1 line, -1 line	2 comments	Download
	M	src/v8natives.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM, modulo one question. http://codereview.chromium.org/7018001/diff/1/src/macros.py File src/macros.py (right): http://codereview.chromium.org/7018001/diff/1/src/macros.py#newcode130 src/macros.py:130: macro TO_OBJECT_INLINE(arg) = ((IS_OBJECT(%IS_VAR(arg)) && ...

9 years, 7 months ago (2011-05-12 16:11:05 UTC) #2

Vitaly Repeshko

9 years, 7 months ago (2011-05-12 16:19:24 UTC) #3

http://codereview.chromium.org/7018001/diff/1/src/macros.py
File src/macros.py (right):

http://codereview.chromium.org/7018001/diff/1/src/macros.py#newcode130
src/macros.py:130: macro TO_OBJECT_INLINE(arg) = ((IS_OBJECT(%IS_VAR(arg)) &&
!IS_NULL_OR_UNDEFINED(arg)) ? arg : ToObject(arg));
On 2011/05/12 16:11:05, Mads Ager wrote:
> I wonder if what we should be using here is %_IsSpecObject?

You're right. It's simpler.

Expand Messages | Collapse Messages