Roll out v1 of the client-side phishing detection model, to replace v0.

Roll out v1 of the client-side phishing detection model, to replace v0.

BUG=82984
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85855

[Brian Ryner, 2011-05-17 23:03:54]

Note: the model file is in the process of being pushed.  It currently returns a
404 but should be live within a couple of hours.

[noelutz, 2011-05-17 23:38:32]

LGTM

On 2011/05/17 23:03:54, Brian Ryner wrote:
> Note: the model file is in the process of being pushed.  It currently returns
a
> 404 but should be live within a couple of hours.

[Brian Ryner, 2011-05-18 18:58:50]

Matt, did you have any comments on this before I submit?  The model file URL is
now live, btw.


On 2011/05/17 23:38:32, noelutz wrote:
> LGTM
> 
> On 2011/05/17 23:03:54, Brian Ryner wrote:
> > Note: the model file is in the process of being pushed.  It currently
returns
> a
> > 404 but should be live within a couple of hours.

[mattm, 2011-05-18 20:32:20]

LGTM,  I wonder if we should have some code to clean up the old file though.

On 2011/05/18 18:58:50, Brian Ryner wrote:
> Matt, did you have any comments on this before I submit?  The model file URL
is
> now live, btw.
> 
> 
> On 2011/05/17 23:38:32, noelutz wrote:
> > LGTM
> > 
> > On 2011/05/17 23:03:54, Brian Ryner wrote:
> > > Note: the model file is in the process of being pushed.  It currently
> returns
> > a
> > > 404 but should be live within a couple of hours.

[Brian Ryner, 2011-05-18 20:38:44]

If Chrome typically tries to clean up obsolete files, I could try to add this. 
Do you have a pointer to any code that might be doing something similar?

On 2011/05/18 20:32:20, mattm wrote:
> LGTM,  I wonder if we should have some code to clean up the old file though.
> 
> On 2011/05/18 18:58:50, Brian Ryner wrote:
> > Matt, did you have any comments on this before I submit?  The model file URL
> is
> > now live, btw.
> > 
> > 
> > On 2011/05/17 23:38:32, noelutz wrote:
> > > LGTM
> > > 
> > > On 2011/05/17 23:03:54, Brian Ryner wrote:
> > > > Note: the model file is in the process of being pushed.  It currently
> > returns
> > > a
> > > > 404 but should be live within a couple of hours.

[mattm, 2011-05-18 21:21:32]

I found SafeBrowsingStoreFile::CheckForOriginalAndDelete in
chrome/browser/safe_browsing/safe_browsing_store_file.cc, but I don't think we
need histograms or anything in this case.  You can just add the clean up code
with a TODO to remove it for m14. (Maybe file a bug if you don't want to
forget.)

I guess the simplest case would just be to use file_util::Delete and ignore the
return value.

On 2011/05/18 20:32:20, mattm wrote:
> LGTM,  I wonder if we should have some code to clean up the old file though.
> 
> On 2011/05/18 18:58:50, Brian Ryner wrote:
> > Matt, did you have any comments on this before I submit?  The model file URL
> is
> > now live, btw.
> > 
> > 
> > On 2011/05/17 23:38:32, noelutz wrote:
> > > LGTM
> > > 
> > > On 2011/05/17 23:03:54, Brian Ryner wrote:
> > > > Note: the model file is in the process of being pushed.  It currently
> > returns
> > > a
> > > > 404 but should be live within a couple of hours.

[Brian Ryner, 2011-05-18 22:42:24]

Added cleanup for the old model file, please take another look.

On 2011/05/18 21:21:32, mattm wrote:
> I found SafeBrowsingStoreFile::CheckForOriginalAndDelete in
> chrome/browser/safe_browsing/safe_browsing_store_file.cc, but I don't think we
> need histograms or anything in this case.  You can just add the clean up code
> with a TODO to remove it for m14. (Maybe file a bug if you don't want to
> forget.)
> 
> I guess the simplest case would just be to use file_util::Delete and ignore
the
> return value.
> 
> On 2011/05/18 20:32:20, mattm wrote:
> > LGTM,  I wonder if we should have some code to clean up the old file though.
> > 
> > On 2011/05/18 18:58:50, Brian Ryner wrote:
> > > Matt, did you have any comments on this before I submit?  The model file
URL
> > is
> > > now live, btw.
> > > 
> > > 
> > > On 2011/05/17 23:38:32, noelutz wrote:
> > > > LGTM
> > > > 
> > > > On 2011/05/17 23:03:54, Brian Ryner wrote:
> > > > > Note: the model file is in the process of being pushed.  It currently
> > > returns
> > > > a
> > > > > 404 but should be live within a couple of hours.

[mattm, 2011-05-18 23:05:39]

lgtm