Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5925)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 7017014: Fix issues when PrerenderContents::Destroy() is called during TabContents destruction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Sync Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_browsertest.cc
===================================================================
--- chrome/browser/prerender/prerender_browsertest.cc (revision 86287)
+++ chrome/browser/prerender/prerender_browsertest.cc (working copy)
@@ -89,7 +89,7 @@
" when testing URL " << prerender_url().path();
// Prerendering RenderViewHosts should be hidden before the first
// navigation, so this should be happen for every PrerenderContents for
- // while a RenderViewHost is created, regardless of whether or not it's
+ // which a RenderViewHost is created, regardless of whether or not it's
// used.
if (new_render_view_host_) {
EXPECT_TRUE(was_hidden_);
@@ -519,9 +519,9 @@
// Renders a page that contains a prerender link to a page that contains an
// iframe with a source that requires http authentication. This should not
// prerender successfully.
-// Flaky, and crbug.com was down when discovered, so no crbug entry.
+// Flaky: http://crbug.com/82913.
IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
- DISABLED_PrerenderHttpAuthentication) {
+ FLAKY_PrerenderHttpAuthentication) {
PrerenderTestURL("files/prerender/prerender_http_auth_container.html",
FINAL_STATUS_AUTH_NEEDED,
1);
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_contents.h » ('j') | chrome/browser/prerender/prerender_contents.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698