Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Side by Side Diff: src/proxy.js

Issue 7017008: Trying to move derived get trap from builtins to global context. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | src/runtime.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 $Proxy.createFunction = function(handler, callTrap, constructTrap) { 56 $Proxy.createFunction = function(handler, callTrap, constructTrap) {
57 handler.callTrap = callTrap 57 handler.callTrap = callTrap
58 handler.constructTrap = constructTrap 58 handler.constructTrap = constructTrap
59 $Proxy.create(handler) 59 $Proxy.create(handler)
60 } 60 }
61 61
62 $Proxy.create = function(handler, proto) { 62 $Proxy.create = function(handler, proto) {
63 if (!IS_SPEC_OBJECT(proto)) proto = $Object.prototype 63 if (!IS_SPEC_OBJECT(proto)) proto = $Object.prototype
64 return %CreateJSProxy(handler, proto) 64 return %CreateJSProxy(handler, proto)
65 } 65 }
66
67
68
69
70 ////////////////////////////////////////////////////////////////////////////////
71 // Builtins
72 ////////////////////////////////////////////////////////////////////////////////
73
74 function DerivedGetTrap(receiver, name) {
75 var desc = this.getPropertyDescriptor(name)
76 if (IS_UNDEFINED(desc)) { return desc; }
77 if ('value' in desc) {
78 return desc.value
79 } else {
80 if (IS_UNDEFINED(desc.get)) { return desc.get; }
81 return desc.get.call(receiver) // The proposal says so...
82 }
83 }
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/runtime.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698