The Rietveld.get_pending_issue() was totally wrong. Fix it.

The Rietveld.get_pending_issue() was totally wrong. Fix it.

I wonder how it worked at all. That explains some weird behavior when it was
ignoring issues recently.

Also enabled limit=1000 in case there's a huge bottleneck.

R=dpranke@chromium.org
BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85516

[Dirk Pranke, 2011-05-16 17:30:06]

LGTM (but this is pretty much a rubber-stamp).

[M-A Ruel, 2011-05-16 19:32:45]

On 2011/05/16 17:30:06, Dirk Pranke wrote:
> LGTM (but this is pretty much a rubber-stamp).

FTR, the relevant code is in
http://code.google.com/p/rietveld/source/browse/branches/chromium/codereview/...
in class SearchForm. The values are NullBooleanField so they accept 1-2-3.

[commit-bot: I haz the power, 2011-05-16 19:38:55]

Presubmit check for 7016038-1 failed and returned exit status 1.

Running presubmit commit checks ...
Syncing rietveld...
Running push-basic.sh
Running save-description-on-failure.sh
Running basic.sh
Running upload-stale.sh
Running upload-local-tracking-branch.sh
Running patch.sh
Running submit-from-new-dir.sh
Running post-dcommit-hook-test.sh
Running hooks.sh
Running abandon.sh
Running tbr.sh
Running upstream.sh

** Presubmit Messages **
You should install python 2.5 and run ln -s $(which python2.5) python.
A great place to put this symlink is in depot_tools.
Otherwise, you break depot_tools on python 2.5, you get to keep the pieces.

** Presubmit ERRORS **
tests/gclient_scm_test.py failed!
Command tests/gclient_scm_test.py returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/depot_tools
...........EE...................
======================================================================
ERROR: testUpdateUnstagedConflict (__main__.GitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 757, in testUpdateUnstagedConflict
    scm.update(options, (), [])
  File "/mnt/data/b/commit-queue/workdir/depot_tools/gclient_scm.py", line 395,
in update
    raise gclient_utils.Error(e.stderr)
Error: error: Your local changes to 'b' would be overwritten by merge. 
Aborting.
Please, commit your changes or stash them before you can merge.


======================================================================
ERROR: testUpdateUnstagedConflict (__main__.GitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_scm_test.py", line 539, in tearDown
    StdoutCheck.tearDown(self)
  File "/mnt/data/b/commit-queue/workdir/depot_tools/tests/super_mox.py", line
100, in tearDown
    self.assertEquals('', sys.stdout.getvalue())
AssertionError: '' != '\n_____ . at refs/heads/master\n'

----------------------------------------------------------------------
Ran 31 tests in 1.098s

FAILED (errors=2)


upstream.sh failed
Command /mnt/data/b/commit-queue/workdir/depot_tools/tests/upstream.sh returned
non-zero exit status 1 in /mnt/data/b/commit-queue/workdir/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
error: unknown switch `B'
usage: git checkout [options] <branch>
   or: git checkout [options] [<branch>] -- <file>...

    -q, --quiet           be quiet
    -b <new branch>       branch
    -l                    log for new branch
    -t, --track           track
    -2, --ours            stage
    -3, --theirs          stage
    -f, --force           force
    -m, --merge           merge
    --conflict <style>    conflict style (merge or diff3)
    -p, --patch           select hunks interactively



Presubmit checks took 353.1s to calculate.