Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 7016001: Simple OAuth1 implementation based on http://code.google.com/chrome/extensions/tut_oauth.html. (Closed)

Created:
9 years, 7 months ago by awong
Modified:
9 years, 7 months ago
Reviewers:
garykac, Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Simple OAuth1 implementation based on http://code.google.com/chrome/extensions/tut_oauth.html. This copies the files from the extensions example. We're okay with this fork as we will replace this with an OAuth2 handler once the server side is setup correctly. BUG=none TEST=manually step through getting/clearing token. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85043

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1119 lines, -3 lines) Patch
M remoting/webapp/me2mom/background.html View 2 chunks +11 lines, -0 lines 0 comments Download
M remoting/webapp/me2mom/choice.html View 1 chunk +4 lines, -1 line 0 comments Download
A remoting/webapp/me2mom/chrome_ex_oauth.html View 1 chunk +27 lines, -0 lines 0 comments Download
A remoting/webapp/me2mom/chrome_ex_oauth.js View 1 chunk +593 lines, -0 lines 0 comments Download
A remoting/webapp/me2mom/chrome_ex_oauthsimple.js View 1 chunk +458 lines, -0 lines 1 comment Download
M remoting/webapp/me2mom/manifest.json View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/webapp/me2mom/remoting.js View 1 chunk +22 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
awong
This should give you OAuth1 tokens + a class which actually signs your requests for ...
9 years, 7 months ago (2011-05-11 19:41:11 UTC) #1
Jamie
LGTM. http://codereview.chromium.org/7016001/diff/1/remoting/webapp/me2mom/chrome_ex_oauthsimple.js File remoting/webapp/me2mom/chrome_ex_oauthsimple.js (right): http://codereview.chromium.org/7016001/diff/1/remoting/webapp/me2mom/chrome_ex_oauthsimple.js#newcode397 remoting/webapp/me2mom/chrome_ex_oauthsimple.js:397: if(!_p){_p='=';}if(!_z){_z=8;}function _f(t,b,c,d){if(t<20){return(b&c)|((~b)&d);}if(t<40){return b^c^d;}if(t<60){return(b&c)|(b&d)|(c&d);}return b^c^d;}function _k(t){return(t<20)?1518500249:(t<40)?1859775393:(t<60)?-1894007588:-899497514;}function _s(x,y){var l=(x&0xFFFF)+(y&0xFFFF),m=(x>>16)+(y>>16)+(l>>16);return(m<<16)|(l&0xFFFF);}function _r(n,c){return(n<<c)|(n>>>(32-c));}function ...
9 years, 7 months ago (2011-05-11 20:41:04 UTC) #2
garykac
9 years, 7 months ago (2011-05-11 20:46:07 UTC) #3
http://codereview.chromium.org/7016001/diff/1/remoting/webapp/me2mom/chrome_e...
> remoting/webapp/me2mom/chrome_ex_oauthsimple.js:397:
> ...
> I think this line might be a tad over the 80-character limit ;)

That's OK as long as it makes the code more readable. ^_^

Powered by Google App Engine
This is Rietveld 408576698