Issue 7015041: [cros] Update default avatars and guest icon

Issue 7015041: [cros] Update default avatars and guest icon (Closed)

Created:
9 years, 7 months ago by whywhat

Modified:
9 years, 5 months ago

Reviewers:
Nikita (slow), unisago

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[cros] Update default avatars and guest icon R=nkostylev@chromium.org BUG=chromium-os:14618 TEST=Verify that images have changed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85606

Patch Set 2 : Fixed size of two images #

Patch Set 3 : Updated images again #

Patch Set 4 : Select the default picture. Added two more avatars. #

Total comments: 2

Patch Set 5 : Fixed comments #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -4 lines)			Patch
M	chrome/app/theme/avatar_beaker.png	View	1 2	Binary file		0 comments	Download
M	chrome/app/theme/avatar_bee.png	View	1 2	Binary file		0 comments	Download
M	chrome/app/theme/avatar_briefcase.png	View	1 2	Binary file		0 comments	Download
M	chrome/app/theme/avatar_circles.png	View	1 2	Binary file		0 comments	Download
M	chrome/app/theme/avatar_cloud.png	View	1 2	Binary file		0 comments	Download
M	chrome/app/theme/avatar_cupcake.png	View	1 2	Binary file		0 comments	Download
M	chrome/app/theme/avatar_day.png	View		Binary file		0 comments	Download
M	chrome/app/theme/avatar_flower.png	View	1 2	Binary file		0 comments	Download
M	chrome/app/theme/avatar_globe.png	View	1 2	Binary file		0 comments	Download
M	chrome/app/theme/avatar_hotair.png	View	1 2	Binary file		0 comments	Download
M	chrome/app/theme/avatar_ladybug.png	View	1 2	Binary file		0 comments	Download
M	chrome/app/theme/avatar_leaf.png	View	1 2	Binary file		0 comments	Download
M	chrome/app/theme/avatar_night.png	View	1 2	Binary file		0 comments	Download
M	chrome/app/theme/avatar_plane.png	View	1 2	Binary file		0 comments	Download
M	chrome/app/theme/avatar_robot_body.png	View	1 2	Binary file		0 comments	Download
M	chrome/app/theme/avatar_robot_head.png	View	1 2	Binary file		0 comments	Download
M	chrome/app/theme/avatar_toolbox.png	View	1 2	Binary file		0 comments	Download
A	chrome/app/theme/avatar_user_color.png	View	1 2 3	Binary file		0 comments	Download
A	chrome/app/theme/avatar_user_enterprise.png	View	1 2 3	Binary file		0 comments	Download
M	chrome/app/theme/login_guest.png	View	1 2	Binary file		0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/default_images_view.h	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/default_images_view.cc	View	1 2 3 4	3 chunks	+11 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/default_user_images.cc	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_image_view.cc	View	1 2 3	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

whywhat

PTAL! I had to add two more images and preselect the default one for new ...

9 years, 7 months ago (2011-05-16 16:01:20 UTC) #3

Nikita (slow)

LGTM http://codereview.chromium.org/7015041/diff/9001/chrome/browser/chromeos/login/default_images_view.cc File chrome/browser/chromeos/login/default_images_view.cc (right): http://codereview.chromium.org/7015041/diff/9001/chrome/browser/chromeos/login/default_images_view.cc#newcode112 chrome/browser/chromeos/login/default_images_view.cc:112: selected_image_index_ = image_index + 1; nit: Please comment ...

9 years, 7 months ago (2011-05-16 16:45:16 UTC) #4

whywhat

http://codereview.chromium.org/7015041/diff/9001/chrome/browser/chromeos/login/default_images_view.cc File chrome/browser/chromeos/login/default_images_view.cc (right): http://codereview.chromium.org/7015041/diff/9001/chrome/browser/chromeos/login/default_images_view.cc#newcode112 chrome/browser/chromeos/login/default_images_view.cc:112: selected_image_index_ = image_index + 1; On 2011/05/16 16:45:16, Nikita ...

9 years, 7 months ago (2011-05-17 12:25:43 UTC) #5

Expand Messages | Collapse Messages