Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: src/hydrogen-instructions.h

Issue 7015039: Removed a "feature envy" bad smell: Moved AssumeRepresentation method to where (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 539 matching lines...) Expand 10 before | Expand all | Expand 10 after
550 virtual bool EmitAtUses() { return false; } 550 virtual bool EmitAtUses() { return false; }
551 Representation representation() const { return representation_; } 551 Representation representation() const { return representation_; }
552 void ChangeRepresentation(Representation r) { 552 void ChangeRepresentation(Representation r) {
553 // Representation was already set and is allowed to be changed. 553 // Representation was already set and is allowed to be changed.
554 ASSERT(!representation_.IsNone()); 554 ASSERT(!representation_.IsNone());
555 ASSERT(!r.IsNone()); 555 ASSERT(!r.IsNone());
556 ASSERT(CheckFlag(kFlexibleRepresentation)); 556 ASSERT(CheckFlag(kFlexibleRepresentation));
557 RepresentationChanged(r); 557 RepresentationChanged(r);
558 representation_ = r; 558 representation_ = r;
559 } 559 }
560 void AssumeRepresentation(Representation r);
560 561
561 virtual bool IsConvertibleToInteger() const { return true; } 562 virtual bool IsConvertibleToInteger() const { return true; }
562 563
563 HType type() const { return type_; } 564 HType type() const { return type_; }
564 void set_type(HType type) { 565 void set_type(HType type) {
565 ASSERT(HasNoUses()); 566 ASSERT(HasNoUses());
566 type_ = type; 567 type_ = type;
567 } 568 }
568 569
569 // An operation needs to override this function iff: 570 // An operation needs to override this function iff:
(...skipping 3325 matching lines...) Expand 10 before | Expand all | Expand 10 after
3895 3896
3896 DECLARE_CONCRETE_INSTRUCTION(In) 3897 DECLARE_CONCRETE_INSTRUCTION(In)
3897 }; 3898 };
3898 3899
3899 #undef DECLARE_INSTRUCTION 3900 #undef DECLARE_INSTRUCTION
3900 #undef DECLARE_CONCRETE_INSTRUCTION 3901 #undef DECLARE_CONCRETE_INSTRUCTION
3901 3902
3902 } } // namespace v8::internal 3903 } } // namespace v8::internal
3903 3904
3904 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 3905 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698