Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5674)

Unified Diff: chrome/browser/sync/engine/syncapi.cc

Issue 7015031: [Sync] Clean up notifications tab in chrome://sync-internals (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add comments Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/sync_internals/notifications.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/engine/syncapi.cc
diff --git a/chrome/browser/sync/engine/syncapi.cc b/chrome/browser/sync/engine/syncapi.cc
index 48327fa25bca18fa4a9dead78f0ac6e59e5b2732..6f2dd5958f7ab56a9783d1a8b56eff2bb8d5703c 100644
--- a/chrome/browser/sync/engine/syncapi.cc
+++ b/chrome/browser/sync/engine/syncapi.cc
@@ -1209,6 +1209,12 @@ class SyncManager::SyncInternal
method_factory_(ALLOW_THIS_IN_INITIALIZER_LIST(this)),
js_directory_change_listener_(ALLOW_THIS_IN_INITIALIZER_LIST(this)) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ // Pre-fill |notification_info_map_|.
+ for (int i = syncable::FIRST_REAL_MODEL_TYPE;
+ i < syncable::MODEL_TYPE_COUNT; ++i) {
+ notification_info_map_.insert(
+ std::make_pair(syncable::ModelTypeFromInt(i), NotificationInfo()));
+ }
}
virtual ~SyncInternal() {
@@ -1607,7 +1613,6 @@ class SyncManager::SyncInternal
ScopedRunnableMethodFactory<SyncManager::SyncInternal> method_factory_;
// Map used to store the notification info to be displayed in about:sync page.
- // TODO(lipalani) - prefill the map with enabled data types.
NotificationInfoMap notification_info_map_;
browser_sync::JsDirectoryChangeListener js_directory_change_listener_;
« no previous file with comments | « chrome/browser/resources/sync_internals/notifications.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698